165030 - UMR in nsGlobalHistory.cpp:1725.

Status: RESOLVED DUPLICATE of bug 164385

(Core Graveyard :: History: Global, defect)

Description

[Peter A Jonsson]

==28062== Conditional jump or move depends on uninitialised value(s)
==28062==    at 0x47690CFC: nsGlobalHistory::SetDirty(void)
(nsGlobalHistory.cpp:1725)
==28062==    by 0x4768C749: nsGlobalHistory::AddPageToDatabase(char const *,
long long) (nsGlobalHistory.cpp:702)
==28062==    by 0x4768BCF7: nsGlobalHistory::AddPage(char const *)
(nsGlobalHistory.cpp:615)
==28062==    by 0x46B0BB6E: nsDocShell::AddToGlobalHistory(nsIURI *)
(nsDocShell.cpp:6220)
==28062==    by 0x46B08FDC: nsDocShell::OnNewURI(nsIURI *, nsIChannel *,
unsigned int) (nsDocShell.cpp:5676)
==28062==    by 0x46B09258: nsDocShell::OnLoadingSite(nsIChannel *)
(nsDocShell.cpp:5713)
==28062==    by 0x46B0292D: nsDocShell::CreateContentViewer(char const *,
nsIRequest *, nsIStreamListener **) (nsDocShell.cpp:4289)
==28062==    by 0x46B31472: nsDSURIContentListener::DoContent(char const *, int,
nsIRequest *, nsIStreamListener **, int *) (nsDSURIContentListener.cpp:110)
==28062==    by 0x45B378CA: nsDocumentOpenInfo::DispatchContent(nsIRequest *,
nsISupports *) (nsURILoader.cpp:358)
==28062==    by 0x45B370C1: nsDocumentOpenInfo::OnStartRequest(nsIRequest *,
nsISupports *) (nsURILoader.cpp:228)
==28062==    by 0x4461E675: nsHttpChannel::ProcessNormal(void)
(nsHttpChannel.cpp:629)
==28062==    by 0x4461DFA3: nsHttpChannel::ProcessResponse(void)
(nsHttpChannel.cpp:531)
==28062==    by 0x4462799D: nsHttpChannel::OnStartRequest(nsIRequest *,
nsISupports *) (nsHttpChannel.cpp:2881)
==28062==    by 0x445B4B30: ??? (nsRequestObserverProxy.cpp:161)
==28062==    by 0x445B3ED8: nsARequestObserverEvent::HandlePLEvent(PLEvent *)
(nsRequestObserverProxy.cpp:115)

Comment 1

[Peter A Jonsson]

Attachment: Only check rv if it has been initialized.

Comment 2

[Andrew Schultz]

After existing for over a year, two people caught this bug within one week.  

valgrind is cool!

*** This bug has been marked as a duplicate of 164385 ***