1650304 - Bypass selections not centered with checkbox in about:profiling

Status: RESOLVED DUPLICATE of bug 1689480

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P3)

Description

[Cristian Fogel [:cfogel]]

Attachment: Screenshot 0002-07-03 at 09.42.23.png

Affected versions

• 79.0b3, 80.0a1 (2020-07-01)

Affected platforms

• Windows 10, macOS 10.15.5, Ubuntu 18;

Steps to reproduce

1. Launch Firefox and access about:profiling
2. Scroll down in the page;

Expected result

• elements are centered as expected;

Actual result

• [Bypass selections above and record all registered threads] is lower than the checkbox;

Regression range

• not a regression, introduced with implementation/enabling of page on [2018-09-07]- [2018-09-09]
• Pushlog: URL;

Additional notes

• attached screenshot with the issue;
• severity-wise it's trivial / S4.

Comment 1

[TANWEER ALI]

Hey, Can I start working on this issue?

Tanweer Ali

Comment 2

[TANWEER ALI]

I have seen about:profiling in my firefox and its still not fixed. I want to work on this issue. Can u help me where to start I am a beginner and exploring codebase of devtools.
Thanks
Tanweer Ali

Comment 3

[Julien Wajsberg [:julienw]]

Thanks for your interest.
Of course you can work on this!

I'd suggest that you first follow the tutorial steps in [1], by using an artifact build when you get the question. Artifact builds make it a lot faster to build firefox when all you want is changing Javascript / CSS stuff, because this doesn't rebuild all the c++/rust code.

The devtools folks also wrote interesting doc in [2] about the process when contributing (how to build, how to refresh, etc).

[1] https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html
[2] https://firefox-source-docs.mozilla.org/devtools/index.html#contributing

In this case I think the fix will be in CSS, the CSS for this component is in [3]. I believe the solution will involve adding a "flex" property somewhere. I suggest to look at the other checkboxes that are correct and you should find the solution.

[3] https://searchfox.org/mozilla-central/source/devtools/client/themes/aboutprofiling.css

Also, [4] is where the DOM is produced. I believe this is correct but I haven't looked closer.

[4] https://searchfox.org/mozilla-central/rev/692a10e624a02fe79bf45046b586e50ea0ff17f1/devtools/client/performance-new/components/Settings.js#315-333

Good luck hunting bugs!

Comment 4

[TANWEER ALI]

Hey Julien
Thanks for assigning me this bug. I will try to resolve it as soon as possible.
Tanweer

Comment 5

[TANWEER ALI]

Attachment: Bug 1650304 - [DevTools] Centre ByPass Selection checkbox in about:profiling. r=julienw

Comment 6

[TANWEER ALI]

Hey Julien,
I have submitted a patch fixing this.

Tanweer Ali

Comment 7

[TANWEER ALI]

Attachment: Bug 1650304 - [Devtools] Center ByPass Selection with Checkbox in about:profiling. r=julienw

Comment 8

[TANWEER ALI]

Attachment: Bug 1650304 - [Devtools] Center ByPass Selection with Checkbox in about:profiling. r=julienw

Comment 9

[Julien Wajsberg [:julienw]]

I think this is fixed by the patch in bug 1689480.

Comment 10

[TANWEER ALI]

ok got it.