1650351 - Land a reftest for bug 1552923

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: reftest-for-bug1552923

I wrote a reftest bug 1552923, but apparently it needs bug 1646629 (a change to make reftest-no-flush work properly), so I am going to defer adding the reftest into this bug.

Comment 1

[Glenn Watson [:gw]]

Hiro, is this still relevant?

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Yes, coincidently Boris is now touching some relevant stuff in bug 1776077.

I will try to see if this reftest now works or not since bug 1646629 landed.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1650351 - A reftest for bug 1552923. r?boris

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2d741f0c573
A reftest for bug 1552923. r=boris

Comment 5

[Cristian Tuns]

Backed out for causing reftest failures on replace-with-new-positive-delay-animation.html

• Backout link
• Push with failures
• Failure Log
• Failure line: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/css-animations/replace-with-new-positive-delay-animation.html == layout/reftests/css-animations/replace-with-new-positive-delay-animation-ref.html | image comparison, max difference: 255, number of differing pixels: 10000
• Analyzer link: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/U8FI2OTATaWg2raUE4niTQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Hmm, it failed on Android. And I suppose just waiting for two frames isn't sufficient for Android. :/

Comment 7

[Hiroyuki Ikezoe (:hiro)]

I am going to skip the reftest on Android. On Android even with waiting for 1s the test fails, the green box doesn't appear, it should be triggered by setting the second animation. When I open the reftest in question with some tweak (using window.onload instead of MozReftestInvalidate) on GeckoView example, the green box appears properly. So I suppose it's an issue in our reftest harness (Android specific, it's weird though) rather than a real issue.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Filed bug 1787682 for the Android failure.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/213ee3519e46
A reftest for bug 1552923. r=boris

Comment 10

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/213ee3519e46