1650656 - Crash in [@ mozilla::net::CookieCommons::SchemeToSchemeType]

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect, P1)

Description

[[:philipp]]

This bug is for crash report bp-c0e829de-1479-441f-bc11-f30f00200610.

Top 10 frames of crashing thread:

0 xul.dll static mozilla::net::CookieCommons::SchemeToSchemeType netwerk/cookie/CookieCommons.cpp:653
1 xul.dll static mozilla::net::CookieCommons::URIToSchemeType netwerk/cookie/CookieCommons.cpp:621
2 xul.dll mozilla::net::CookieService::GetCookiesForURI netwerk/cookie/CookieService.cpp:859
3 xul.dll mozilla::net::CookieServiceParent::TrackCookieLoad netwerk/cookie/CookieServiceParent.cpp:99
4 xul.dll mozilla::dom::ContentParent::UpdateCookieStatus dom/ipc/ContentParent.cpp:5572
5 xul.dll mozilla::dom::ContentParent::AboutToLoadHttpFtpDocumentForChild dom/ipc/ContentParent.cpp:5614
6 xul.dll mozilla::net::FTPChannelParent::OnStartRequest netwerk/protocol/ftp/FTPChannelParent.cpp:395
7 xul.dll mozilla::net::DocumentLoadListener::ResumeSuspendedChannel netwerk/ipc/DocumentLoadListener.cpp:959
8 xul.dll mozilla::net::DocumentLoadListener::FinishReplacementChannelSetup netwerk/ipc/DocumentLoadListener.cpp:843
9 xul.dll mozilla::net::DocumentLoadListener::RedirectToRealChannelFinished netwerk/ipc/DocumentLoadListener.cpp:755

this crash signature is starting to show up in firefox 79 with MOZ_CRASH(Unsupported scheme type) from bug 1638358. one user comment mentioned "tried to use ftp" at the time of the crash.

Comment 1

[Andrea Marchesini [:baku]]

This has been fixed in bug 1642971.

Comment 2

[[:philipp]]

hi, bug 1642971 received a patch during the 79 nightly cycle - crashes with the signature here are still showing up from 79.0b though.
even if it's the same issue, it seems that the crash is not fixed in all cases yet.

Comment 3

[Andrea Marchesini [:baku]]

Oh! Yes, that crash report was fixed (it's about FTP) but others are not. I just sent a fix.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1650656 - Call CookieCommons::SchemeToSchemeType only when the scheme is supported, r?mayhemer

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d90c8b4228bd
Call CookieCommons::SchemeToSchemeType only when the scheme is supported, r=mayhemer

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/d90c8b4228bd

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:baku, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Andrea Marchesini [:baku]]

Comment on attachment 9161818 [details]
Bug 1650656 - Call CookieCommons::SchemeToSchemeType only when the scheme is supported, r?mayhemer

Beta/Release Uplift Approval Request

• User impact if declined: A crash can occur in debug builds
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch adds a scheme check in any of the cookieService methods, bailing out if the scheme is not supported. Low risk.
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9161818 [details]
Bug 1650656 - Call CookieCommons::SchemeToSchemeType only when the scheme is supported, r?mayhemer

Approved for 79.0b8.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cb8033b28a08