1638358 - Schemeful Same-Site

Status: RESOLVED FIXED

(Core :: Networking: Cookies, task, P2)

Description

[Andrea Marchesini [:baku]]

https://github.com/sbingler/schemeful-same-site:
"Modify SameSite’s implementation in the user agent to consider origins with different schemes as cross-site. Thus https://site.example and http://site.example would now be considered cross-site.
Part of this effort will be to update Incrementally Better Cookies to match the intended behavior."

This feature will be implemented behind pref: network.cookie.sameSite.schemeful

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1638358 - Cookie Schemeful Same-Site - part 1 - scheme map in nsICookie, r?mayhemer

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1638358 - Cookie Schemeful Same-Site - part 2 - schemeMap in the cookie DB, r?mayhemer

Depends on D75624

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r?mayhemer

Depends on D75626

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1638358 - Cookie Schemeful Same-Site - part 4 - tests for cookie scheme merging, r?mayhemer

Depends on D75627

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1638358 - Cookie Schemeful Same-Site - part 5 - schemeful comparison, r?mayhemer

Depends on D75628

Comment 6

[Andrea Marchesini [:baku]]

Attachment: Bug 1638358 - Cookie Schemeful Same-Site - part 6 - console messages, r?mayhemer

Depends on D75629

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d284b50551ab
Cookie Schemeful Same-Site - part 1 - scheme map in nsICookie, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/31101054c52c
Cookie Schemeful Same-Site - part 2 - schemeMap in the cookie DB, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/2156294cb158
Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
https://hg.mozilla.org/integration/autoland/rev/1a85cc92d2fb
Cookie Schemeful Same-Site - part 4 - tests for cookie scheme merging, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/a45df1876e37
Cookie Schemeful Same-Site - part 5 - schemeful comparison, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/745eab35e851
Cookie Schemeful Same-Site - part 6 - console messages, r=mayhemer

Comment 8

[Dorel Luca [:dluca]]

Backed out 6 changesets (bug 1638358) for XPCShell failures in netwerk/cookie/test/unit/test_schemeMap.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304513171&repo=autoland&lineNumber=3076

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=745eab35e851f54f62e9e94d6028cb955244d797

Backout:
https://hg.mozilla.org/integration/autoland/rev/3a5a2880ed65f7390ec6abbe84dc39c2b680e375

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cddeada5c4a6
Cookie Schemeful Same-Site - part 1 - scheme map in nsICookie, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/05a62901a3f5
Cookie Schemeful Same-Site - part 2 - schemeMap in the cookie DB, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/932a3fdbd07c
Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
https://hg.mozilla.org/integration/autoland/rev/fad2ba760157
Cookie Schemeful Same-Site - part 4 - tests for cookie scheme merging, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/532731e94bb2
Cookie Schemeful Same-Site - part 5 - schemeful comparison, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/4e8fbe01aa38
Cookie Schemeful Same-Site - part 6 - console messages, r=mayhemer

Comment 10

[Noemi Erli[:noemi_erli]]

Backed out 6 changesets (Bug 1638358) for causing failures in test_Chrome_cookies.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=A79qvrdQSrGAHmzNroOPbg-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=4e8fbe01aa38990c2c4348a42a6cf343f66080f7

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304552835&repo=autoland&lineNumber=4479

Backout: https://hg.mozilla.org/integration/autoland/rev/70bab29e077c8c87144d52cc6abb1d99685ef00b

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ac06f3992f4
Cookie Schemeful Same-Site - part 1 - scheme map in nsICookie, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/0219ef931cd9
Cookie Schemeful Same-Site - part 2 - schemeMap in the cookie DB, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/e91292c7c719
Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
https://hg.mozilla.org/integration/autoland/rev/2c873c72bf1f
Cookie Schemeful Same-Site - part 4 - tests for cookie scheme merging, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/39f2e21623aa
Cookie Schemeful Same-Site - part 5 - schemeful comparison, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/beb85cf281d5
Cookie Schemeful Same-Site - part 6 - console messages, r=mayhemer

Comment 12

[Razvan Maries]

Backed out for perma failures on browser_webconsole_navigate_to_parse_error.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-devtools-chrome-e10s-11%2Cm%28dt11%29&revision=beb85cf281d516fdba58a787057d83e815f67e5b&selectedTaskRun=VwIdN-K7TNW9i2I4o5p8AA-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304620575&repo=autoland&lineNumber=89928

Backout: https://hg.mozilla.org/integration/autoland/rev/ede9a8561051bdba21e06de988cf358a37ebfe55

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87e9d0ed3982
Cookie Schemeful Same-Site - part 1 - scheme map in nsICookie, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/6bc05236afb4
Cookie Schemeful Same-Site - part 2 - schemeMap in the cookie DB, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/d213264c1379
Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
https://hg.mozilla.org/integration/autoland/rev/33ad5fa05209
Cookie Schemeful Same-Site - part 4 - tests for cookie scheme merging, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/89e396b2896e
Cookie Schemeful Same-Site - part 5 - schemeful comparison, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/286e0c83eb30
Cookie Schemeful Same-Site - part 6 - console messages, r=mayhemer

Comment 14

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_webconsole_network_messages_status_code.js

backout: https://hg.mozilla.org/integration/autoland/rev/852f0a4255cbcee5a221bfa1c5d38b540500d304

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=VpixAeH-QlyfuTbkMnn1UQ-0&revision=286e0c83eb307aaa499a8ce385df6289ccdd1f68&searchStr=devtools

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304699347&repo=autoland&lineNumber=87151

[task 2020-06-02T10:31:25.636Z] 10:31:25 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 78}]
[task 2020-06-02T10:31:25.637Z] 10:31:25 INFO - Toolbox opened and focused
[task 2020-06-02T10:31:25.637Z] 10:31:25 INFO - XHR executed
[task 2020-06-02T10:31:25.637Z] 10:31:25 INFO - Console message: [JavaScript Warning: "Cookie “foo” has been treated as cross-site against “http://example.com/browser/devtools/client/webconsole/test/browser/test-data.json” because the scheme does not match." {file: "http://example.com/browser/devtools/client/webconsole/test/browser/test-data.json" line: 0}]
[task 2020-06-02T10:31:25.638Z] 10:31:25 INFO - Network message found.
[task 2020-06-02T10:31:25.638Z] 10:31:25 INFO - Buffered messages finished
[task 2020-06-02T10:31:25.639Z] 10:31:25 INFO - TEST-UNEXPECTED-FAIL | devtools/client/webconsole/test/browser/browser_webconsole_network_messages_status_code.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_network_messages_status_code.js:43 - TypeError: can't access property "title", statusCodeNode is null
[task 2020-06-02T10:31:25.639Z] 10:31:25 INFO - Stack trace:
[task 2020-06-02T10:31:25.639Z] 10:31:25 INFO - task@chrome://mochitests/content/browser/devtools/client/webconsole/test/browser/browser_webconsole_network_messages_status_code.js:43:1
[task 2020-06-02T10:31:25.639Z] 10:31:25 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1064:34
[task 2020-06-02T10:31:25.639Z] 10:31:25 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1104:11
[task 2020-06-02T10:31:25.639Z] 10:31:25 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:927:14
[task 2020-06-02T10:31:25.639Z] 10:31:25 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:918:23
[task 2020-06-02T10:31:25.639Z] 10:31:25 INFO - Leaving test bound task
[task 2020-06-02T10:31:26.179Z] 10:31:26 INFO - Removing tab.
[task 2020-06-02T10:31:26.179Z] 10:31:26 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-06-02T10:31:26.195Z] 10:31:26 INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-06-02T10:31:26.197Z] 10:31:26 INFO - GECKO(2566) | console.warn: "IGNORED REDUX ACTION:" ({type:"AUTOCOMPLETE_CLEAR"})
[task 2020-06-02T10:31:26.214Z] 10:31:26 INFO - Tab removed and finished closing
[task 2020-06-02T10:31:26.251Z] 10:31:26 INFO - TEST-PASS | devtools/client/webconsole/test/browser/browser_webconsole_network_messages_status_code.js | The main process DevToolsServer has no pending connection when the test ends -
[task 2020-06-02T10:31:26.267Z] 10:31:26 INFO - GECKO(2566) | MEMORY STAT | vsize 20976666MB | residentFast 2614MB

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df19526c4106
Cookie Schemeful Same-Site - part 1 - scheme map in nsICookie, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/c5976df6c8d1
Cookie Schemeful Same-Site - part 2 - schemeMap in the cookie DB, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/267b2d5c7eb6
Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
https://hg.mozilla.org/integration/autoland/rev/dff1c1aca50c
Cookie Schemeful Same-Site - part 4 - tests for cookie scheme merging, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/3ce54e39ebcd
Cookie Schemeful Same-Site - part 5 - schemeful comparison, r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/2c1e8f5b08a2
Cookie Schemeful Same-Site - part 6 - console messages, r=mayhemer

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/df19526c4106
https://hg.mozilla.org/mozilla-central/rev/c5976df6c8d1
https://hg.mozilla.org/mozilla-central/rev/267b2d5c7eb6
https://hg.mozilla.org/mozilla-central/rev/dff1c1aca50c
https://hg.mozilla.org/mozilla-central/rev/3ce54e39ebcd
https://hg.mozilla.org/mozilla-central/rev/2c1e8f5b08a2

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5e11fc413ca8
Port bug 1638358 - New argument to nsICookieManager.add. rs=bustage-fix