Closed Bug 1650719 Opened 4 years ago Closed 4 years ago

Scrolling about:config is jank

Categories

(Core :: Layout, defect)

defect

Tracking

()

VERIFIED FIXED
mozilla80
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox78 --- unaffected
firefox79 --- wontfix
firefox80 --- verified

People

(Reporter: blakewolf, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

  1. Go to about:config
  2. Hit "Show All"
  3. Grab the scrollbar and drag it down slightly

Actual results:

When dragging the scrollbar down slightly, it should only move down a few lines

Expected results:

When dragging the scrollbar down slightly, it shouldn't jump like it does

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Hi,

I have managed to reproduce this issue on Beta 79.0b6 and latest Nightly 80.0a1 (2020-07-09) using Windows 10. Not reproducible on Release 78.0.1.

Further, I will move this over to a component so developers can take a look over it. If this is not the correct component please feel free to change it to an appropriate one.

This is a regression, here is the pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=76bffd1b3c6ecdba621930c770c52aae6e6205cc&tochange=1004d422aedb5994f9f2949fd4a4c67bc89e22c7

Thanks for your report.

Status: UNCONFIRMED → NEW
Component: Untriaged → Layout
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Version: 78 Branch → Trunk

mozregression narrows it further for me down to bug 1647871. Emilio, do you want to take a look?

Severity: -- → S4
Flags: needinfo?(emilio)
Regressed by: 1647871
Has Regression Range: --- → yes
Assignee: nobody → emilio

This offset was reset in one of the two codepaths of D80723, but turns
out it's important for same-origin documents that are also
root-content-documents, like about: pages in the parent process, which
happened to hit the codepath that did not reset it. :(

Flags: needinfo?(emilio)

Comment on attachment 9165500 [details]
Bug 1650719 - Don't lose the rect offset from the composition bounds. r=kats,hiro

Beta/Release Uplift Approval Request

  • User impact if declined: Some internal pages that run in the parent process would jump when scrolling.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): One-liner that restores pre-existing behavior.
  • String changes made/needed: none
Attachment #9165500 - Flags: approval-mozilla-release?
Flags: qe-verify+
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9c57e70c264d Don't lose the rect offset from the composition bounds. r=kats
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
QA Whiteboard: [qa-triaged]

Verified - Fixed in latest Nightly 80.0a1 (build id: 20200723095657) using Windows 10 and Ubuntu 18.04.

Comment on attachment 9165500 [details]
Bug 1650719 - Don't lose the rect offset from the composition bounds. r=kats,hiro

80 ships next week, and there are no plans for a 79 dot release

Attachment #9165500 - Flags: approval-mozilla-release? → approval-mozilla-release-
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: