1647871 - Simplify the code to get the composition bounds on android to not rely on the widget size.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1647871 - Simplify content viewer composition size code. r=kats!,hiro!

This should be equivalent because:

• Content viewer size and widget size should eventually be the same always
  (modulo mid-resize, see bug 1645954).

• Only the root content document has a widget on android (the puppet widget).

• Only the root content document has a dynamic toolbar.

• We were only calling this on the root document, which has no parent pres
  context (at least with e10s). Without e10s we could have a chrome
  prescontext (not sure it that ends up being a parent in the pres context
  chain), but we should never change the resolution of that one, so I think
  aScaleContentViewerSize is just useless.

This avoids having two sources of truth by always checking the content viewer
size without subtracting the dynamic toolbar max size.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1647871 - Fix a typo in a dynamic toolbar unit test. r=#geckoview-reviewers

No behavior change actually (as instant is the default behavior), but I
just noticed it while debugging these.

Depends on D80723

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1647871 - Remove AutoResizeReflowSquasher. r=kats

After the above, I don't think this is needed anymore, because we
shouldn't be looking at the widget size from layout.

It also shouldn't cause more reflows on desktop at least, because of the
early out in ResizeReflowIgnoreOverride before calling
SimpleResizeReflow().

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1647871 - Remove nsIWidget::GetCompositionSize(). r=kats

No longer called. This was done as an optimization for OOP iframes, but
it affects the scrollport so it's clearly not sound (the visible rect
shouldn't affect the layout scroll port).

If very tall OOP iframes are a problem somehow, it's something that we
need to deal with in another place. It was, in fact, removed for
top-level remote iframes because of bug 1554861 and other regressions.

Depends on D80731

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/730dac40b4ba
Simplify content viewer composition size code. r=kats,hiro
https://hg.mozilla.org/integration/autoland/rev/a5af9ecdecd5
Fix a typo in a dynamic toolbar unit test. r=geckoview-reviewers,agi

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/345be10ae3f6
Remove AutoResizeReflowSquasher. r=kats
https://hg.mozilla.org/integration/autoland/rev/8bde5b74dd1b
Remove nsIWidget::GetCompositionSize(). r=kats

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/730dac40b4ba
https://hg.mozilla.org/mozilla-central/rev/a5af9ecdecd5
https://hg.mozilla.org/mozilla-central/rev/345be10ae3f6
https://hg.mozilla.org/mozilla-central/rev/8bde5b74dd1b