1650794 - Refactor subdialogs.js to reusable JSM

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, enhancement, P1)

Description

[Emma Zühlcke [:emz]]

We would like to re-use the SubDialog classes from subdialogs.js for a dialog box on tab level.

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1650794 - Refactor subdialogs.js to reusable SubDialog.jsm. r=gijs!

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1650794 - Extended SubDialogManager to support queuing dialogs. r=gijs!

Depends on D82405

Comment 3

[Sam Foster [:sfoster] (he/him)]

Taking a guess at priority for triage, please correct as necessary.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45b3d9917fb3
Refactor subdialogs.js to reusable SubDialog.jsm. r=Gijs,preferences-reviewers
https://hg.mozilla.org/integration/autoland/rev/5ffeb4bf7fa5
Extended SubDialogManager to support queuing dialogs. r=Gijs

Comment 5

[Richard Marti (:Paenglab)]

Great you put this JSM in toolkit. Thunderbird could use it too as we use now our own subdialogs.js. The only problem is, that we insert dialog.css from "chrome://messenger/skin/preferences/dialog.css" which has some differences from the browser one. Would it be somehow possible to load the stylesheet depending on the app that uses the JSM? Or is there a different solution?

Comment 6

[Emma Zühlcke [:emz]]

Oh I see, the default list of injected stylesheets still references a CSS from preferences. To make it more modular we can probably just remove the default entries from the injectedStyleSheets array and let the consumers provide it.

Comment 7

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cmochitests%2Ctest-linux1804-64-asan%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&revision=5ffeb4bf7fa58865efb40b1196f9d3c5bdc589e3&failure_classification_id=2

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309123905&repo=autoland&lineNumber=8467

Backout: https://hg.mozilla.org/integration/autoland/rev/02fa37a7e4c19ff4e64f2a6f29ed618185353486

Comment 8

[Emma Zühlcke [:emz]]

(In reply to Richard Marti (:Paenglab) from comment #5)

Great you put this JSM in toolkit. Thunderbird could use it too as we use now our own subdialogs.js. The only problem is, that we insert dialog.css from "chrome://messenger/skin/preferences/dialog.css" which has some differences from the browser one. Would it be somehow possible to load the stylesheet depending on the app that uses the JSM? Or is there a different solution?

I've talked to :gjis to confirm. I'll move the preferences stylesheet to be passed by the consumer and we'll land the JSM with only common.css. That way it should also be compatible with Thunderbird.

Comment 9

[Richard Marti (:Paenglab)]

Many thanks.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4670b0d08306
Refactor subdialogs.js to reusable SubDialog.jsm. r=Gijs,preferences-reviewers
https://hg.mozilla.org/integration/autoland/rev/f334186f5c18
Extended SubDialogManager to support queuing dialogs. r=Gijs

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/4670b0d08306
https://hg.mozilla.org/mozilla-central/rev/f334186f5c18