Closed
Bug 1652057
Opened 5 years ago
Closed 5 years ago
Port bug 1650794: Refactor subdialogs.js to reusable JSM
Categories
(Thunderbird :: Preferences, task)
Thunderbird
Preferences
Tracking
(thunderbird_esr78 unaffected, thunderbird79 unaffected)
RESOLVED
FIXED
Thunderbird 80.0
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
| thunderbird79 | --- | unaffected |
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
|
35.53 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Bug 1650794 moved the subdialogs.js to a JSM. We can now use this too and need no forked subdialogs.js.
|
Assignee | |
Comment 1•5 years ago
|
||
Remove subdialogs.js and use the JSM.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9162846 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Ah, forgot: this is a port of https://hg.mozilla.org/mozilla-central/rev/4670b0d08306.
|
||
Comment 3•5 years ago
|
||
Comment on attachment 9162846 [details] [diff] [review]
1652057-use-subdialogs-JSM.patch
Review of attachment 9162846 [details] [diff] [review]:
-----------------------------------------------------------------
Nice! Thanks Richard, r=mkmelin
Attachment #9162846 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•5 years ago
|
status-thunderbird79:
--- → unaffected
Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 80.0
Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/a7f77a8c8a01
Port bug 1650794: Refactor subdialogs.js to reusable JSM. r=mkmelin
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/9f9c8e220492
follow-up - Fix broken test. rs=bustage-fix DONTBUILD
|
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•