Closed Bug 1650981 Opened 3 months ago Closed 3 months ago

Do not send TIME_TO_FIRST_INTERACTION_MS from cross process iframes

Categories

(Core :: General, task)

task

Tracking

()

RESOLVED FIXED
mozilla80
Fission Milestone M6b
Tracking Status
firefox80 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In nsPresContext::RecordInteractionTime (which is a function to generate TIME_TO_FIRST_INTERACTION_MS) uses GetToplevelContentDocumentPresContext, in cross-process documents, GetToplevelContentDocumentPresContext doesn't return the top level content document's pres context, it returns in-process top level one. So for example, document A -> document B, and they are different origin, B's GetToplevelContentDocumentPresContext is the B's pres context, not A's. That means we send the telemetry data from cross-process iframes. (That said, I've never confirmed it)

Hiro, will you be able to fix this?

Fission Milestone: --- → M6b
Flags: needinfo?(hikezoe.birchill)

Does this bug cause users to report incorrect TIME_TO_FIRST_INTERACTION_MS telemetry data?

(In reply to Chris Peterson [:cpeterson] from comment #2)

Does this bug cause users to report incorrect TIME_TO_FIRST_INTERACTION_MS telemetry data?

Yes, I believe so.

Assignee: nobody → hikezoe.birchill
Status: NEW → ASSIGNED
Flags: needinfo?(hikezoe.birchill)
Pushed by hikezoe.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0aee39ac273
Send TIME_TO_FIRST_INTERACTION_MS only from the top level content. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.