Closed Bug 1651209 Opened 4 years ago Closed 4 years ago

HTTPS Only Mode - Add 'releaseChannelCollection' to telemetry probes

Categories

(Core :: DOM: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: julianwels, Assigned: julianwels)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

Bug 1627206 and bug 1620244 added telemetry probes for HTTPS-Only mode. In both patches, I forgot to add releaseChannelCollection: opt-out which I'd like to fix with this bug.

Hi Tim, should I file a new data review request for this patch?
The old ones already said Which release channels? All, but I want to make sure :)

Also, the source docs mention:

Keyed histograms are currently not supported in the histogram change detector.

Do you know if this is a problem here?

Flags: needinfo?(tdsmith)

No, pointing to the reviews at https://bugzilla.mozilla.org/show_bug.cgi?id=1627206#c3 and https://bugzilla.mozilla.org/show_bug.cgi?id=1620244#c2 is great, thanks.

Keyed histograms are currently not supported in the histogram change detector.

Do you know if this is a problem here?

The histogram change detector is supposed to provide some alerting if values change suddenly; I'm not actually sure it's still operating. It shouldn't be a concern.

Flags: needinfo?(tdsmith)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58c0fc01bb98
Added releaseChannelCollection to HTTPS-Only Mode telemetry probes r=ckerschb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: