Don't build nsSTSPreloadList.h during export
Categories
(Firefox Build System :: General, task)
Tracking
(firefox80 fixed)
| Tracking | Status | |
|---|---|---|
| firefox80 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
It currently takes 25s to build it, and is the long pole preventing export from finishing earlier, while there is actually only one source file that needs it.
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
Generated files marked as "required during compile" are limited to a
number of extensions, most of which are source file types, so they get
generated when compiling the corresponding object file. Other types,
though, are currently handled via EXTRA_DEPS, which is clunky.
As of now, these other types are limited to link-related items, but more
would be useful (e.g. .inc files, which are only included in one
location).
This however works against the static analysis tasks (coverity and
clang-tidy), which currently rely on everything they need being created
via the export tier. That excludes using EXTRA_DEPS-based hacks.
We create a "pre-compile" tier, that is not used during a normal build,
but can be invoked manually, which the static analysis tasks will do.
|
|
Assignee | |
Comment 3•4 years ago
|
||
This makes dir/target, dir/target-objects, etc. depend on
dir/pre-compile, which ensures all items in the pre-compile pseudo-tier
are built before entering in the directory they are defined in, during
the compile tier. This removes the need for EXTRA_DEPS hacks.
|
|
Assignee | |
Comment 4•4 years ago
|
||
All of them are only used in one source file, in the same directory
where they are generated.
|
||
Updated•4 years ago
|
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/1050d8b1456c Add a pre-compile pseudo-tier. r=firefox-build-system-reviewers,rstewart https://hg.mozilla.org/integration/autoland/rev/71a9a35ac0a4 Hook the pre-compile pseudo-tier in the compile graph. r=nalexander https://hg.mozilla.org/integration/autoland/rev/f71efbe9b907 Move .inc files to the pre-compile pseudo-tier. r=nalexander https://hg.mozilla.org/integration/autoland/rev/c0d50919cb24 Build the STS preload list as a .inc file. r=rstewart,nalexander
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1050d8b1456c
https://hg.mozilla.org/mozilla-central/rev/71a9a35ac0a4
https://hg.mozilla.org/mozilla-central/rev/f71efbe9b907
https://hg.mozilla.org/mozilla-central/rev/c0d50919cb24
Description
•