1651308 - browser.folders.delete does not work with IMAP

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Geoff Lankow (:darktrojan)]

Calling browser.folders.delete on an IMAP folder throws NS_ERROR_ILLEGAL_VALUE from the call to nsIMsgFolder.deleteSubFolders.

Comment 1

[Geoff Lankow (:darktrojan)]

nsImapMailFolder::DeleteSubFolders insists on having a msgWindow argument so that it can pop up a confirmation prompt. nsMsgDBFolder::DeleteSubFolders does not. Without a msgWindow, it just moves the folder directly to the trash, or if it's already there, deletes it permanently.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1651308 - Fix browser.folders.delete on IMAP accounts

Depends on D83911

Comment 3

[Geoff Lankow (:darktrojan)]

Actually, let's not. There's dependencies that aren't done yet.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c01f0d70a895
Fix browser.folders.delete on IMAP accounts r=mkmelin

Comment 5

[Magnus Melin [:mkmelin]]

Uplift to 78?

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9168351 [details]
Bug 1651308 - Fix browser.folders.delete on IMAP accounts

[Approval Request Comment]
Regression caused by (bug #): Never worked.
User impact if declined: This will continue to not work for extensions. Apparently it's hardly ever used but it might as well work.
Testing completed (on c-c, etc.): On beta for all of 81 cycle.
Risk to taking this patch (and alternatives if risky): "Meh."

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9168351 [details]
Bug 1651308 - Fix browser.folders.delete on IMAP accounts

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.3.0:
https://hg.mozilla.org/releases/comm-esr78/rev/e863b3edda80