add mochitest for viewing openpgp messages
Categories
(MailNews Core :: Security: OpenPGP, task)
Tracking
(thunderbird_esr78+ fixed)
People
(Reporter: mkmelin, Assigned: lasana)
Details
Attachments
(1 file, 2 obsolete files)
140.50 KB,
patch
|
mkmelin
:
review+
wsmwk
:
approval-comm-esr78+
|
Details | Diff | Splinter Review |
We should add mochitests that open various kinds of openpgp messages and check that the UI is appropriate.
The UI is still a bit in flux, so let's not check too much details. The details can be adjusted later once the UI is more finalized.
Messages to start with:
- no security (normal)
- signed
- encrypted, not signed
- encrypted and signed
- has autocrypt header
- inline PGP
Then we can move on to more problematic cases...
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Is there a way to create mock email accounts for testing? I generated keys based on my own emails and have been sending messages to myself to get encrypted/signed eml files. I'm realizing that I can't remove any of the contents or the signature fails (doh!).
Assignee | ||
Comment 2•4 years ago
|
||
Never-mind. I think I found a way using the local folders.
Assignee | ||
Comment 3•4 years ago
|
||
Added some tests, keys and helper functions for importing them. I'm not too sure how to generate an inline OpenPGP message, I need some guidance there.
Of the tests added, one will fail, the case where we open a trusted, encrypted message without a signature and no public key. The signed icon is displayed. Is this a bug? I'll update the test if it isn't.
Reporter | ||
Comment 4•4 years ago
|
||
An encrypted-only message from (?) someone trusted should not show as signed. If it does that's a bug.
Reporter | ||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
Updated to include various feedback. The issue I mentioned previously with the icons no longer happens.
Assignee | ||
Comment 7•4 years ago
•
|
||
These tests fail on Windows with (NS_ERROR_NOT_AVAILABLE) [nsIMsgAccountManager.createIncomingServer]" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)
.
Am I doing something wrong with this API? Thoughts?
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 8•4 years ago
|
||
Ran another try job today. Windows still fails:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&selectedTaskRun=DOK0Q_iCSqu1NoOzZ973qg.0
Reporter | ||
Comment 9•4 years ago
|
||
Assignee | ||
Comment 10•4 years ago
|
||
Update for feedback and recent UI changes. I believe I figured out the windows issue, movemail can't be used on windows.
Reporter | ||
Comment 11•4 years ago
|
||
Reporter | ||
Updated•4 years ago
|
Comment 12•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/8581dab5fac5
Add initial mochitests for opening various OpenPGP messages. r=mkmelin
Reporter | ||
Comment 13•4 years ago
|
||
Comment on attachment 9175591 [details] [diff] [review]
mochitestsv3.patch
[Approval Request Comment]
Test only, will give us more confidence OpenPGP works on 78.
Comment 14•4 years ago
|
||
Comment on attachment 9175591 [details] [diff] [review]
mochitestsv3.patch
[Triage Comment]
Approved for esr78
Comment 15•4 years ago
|
||
bugherder uplift |
Thunderbird 78.3.2:
https://hg.mozilla.org/releases/comm-esr78/rev/bcb89c53ba99
Description
•