Closed Bug 1651605 Opened 4 years ago Closed 4 years ago

Disable Service Worker Debugging

Categories

(DevTools :: Debugger, task, P2)

task

Tracking

(firefox79 fixed, firefox80 fixed)

RESOLVED FIXED
Firefox 80
Tracking Status
firefox79 --- fixed
firefox80 --- fixed

People

(Reporter: Honza, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Data coming from our SW experiment are indicating 7% decrease in user engagement and also, opening the Debugger panel is slower. We decided to disable SW support on all channels for now.

Data report:
https://metrics.mozilla.com/~sguha/mz/ds-455/code.1.html

This should be done in Fx80

Honza

The patch should also be uplifted to 79

Honza

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED

We ran an experiment to assess the impact of the feature.
We could verify a significant performance impact on the opening times for the debugger.
It also led to a decrease in overall devtools usage and retention.
Therefore we are disabling the feature until we can implement it with better performance.
This should be implemented with https://bugzilla.mozilla.org/show_bug.cgi?id=1651522

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c48ff27577f Disable Service Worker support in DevTools Debugger r=Honza

Comment on attachment 9163182 [details]
Bug 1651605 - Disable Service Worker support in DevTools Debugger

Beta/Release Uplift Approval Request

  • User impact if declined: Service Worker support in debugger severely impacts the performance of DevTools.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is only a preference flip. This preference was false on all channels except Nightly.
    We are just setting it back to false everywhere, this should have no impact.
  • String changes made/needed:
Attachment #9163182 - Flags: approval-mozilla-beta?
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80

Comment on attachment 9163182 [details]
Bug 1651605 - Disable Service Worker support in DevTools Debugger

Approved for 79.0b8.

Attachment #9163182 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: