1651607 - Expose SW Debugging in Experiments panel

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Support for Service Worker debugging is disabled for now, but it would be great to keep collecting feedback from users. Let's make the feature a bit more visible by introducing it in the new "Experiments" section in about:preferences#experimental

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Some instructions how to proceed here:

1. The core of the work is to define the new feature in toolkit/components/featuregates/Features.toml

2. Detailed documentation is here: https://firefox-source-docs.mozilla.org/toolkit/components/featuregates/featuregates/index.html

3. An example patch (sameSite Cookie): https://phabricator.services.mozilla.com/D82561

4. Another example patch (multiple features added) https://phabricator.services.mozilla.com/D81623

Honza

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1651607 - Expose SW Debugging in Experiments panel

Add a new section to about:preferences experiments to toogle the devtools.debugger.features.windowless-service-workers preference

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

The patch should be uplifted to 79 as soon as tested in Nightly
Honza

Comment 4

[Julian Descottes [:jdescottes]]

ni myself to remember to uplift.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad00c65bf058
Expose SW Debugging in Experiments panel r=Honza,Pike,preferences-reviewers,mstriemer

Comment 6

[Julian Descottes [:jdescottes]]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #3)

The patch should be uplifted to 79 as soon as tested in Nightly
Honza

Actually I am not sure about this. I think the experiments panel is Nightly only? (it is called "Nightly Experiments" afterall)
Are you sure we need to uplift this?

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ad00c65bf058

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Julian Descottes [:jdescottes] from comment #6)

Actually I am not sure about this. I think the experiments panel is Nightly only? (it is called "Nightly Experiments" afterall)
Are you sure we need to uplift this?

Good call. The "Nightly Experiments" section UI is hidden behind "browser.preferences.experimental", which is true only in Nightly
https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/browser/app/profile/firefox.js#764-768
(and there is likely not mach users who flipped that for other channels)

So, I agree, we don't have to uplift.

Honza