Crash in [@ mozilla::layers::WebRenderCommandBuilder::Destroy] on macOS
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox-esr78 | --- | disabled |
firefox78 | --- | disabled |
firefox79 | --- | disabled |
firefox80 | --- | disabled |
People
(Reporter: sefeng, Unassigned)
References
(Blocks 2 open bugs)
Details
(Keywords: crash)
Crash Data
This bug is for crash report bp-d4993484-c5d7-4bb2-89b6-4dd090200707.
Top 10 frames of crashing thread:
0 XUL mozilla::layers::WebRenderCommandBuilder::Destroy gfx/layers/wr/WebRenderCommandBuilder.cpp:1524
1 XUL mozilla::layers::WebRenderLayerManager::DoDestroy gfx/layers/wr/WebRenderLayerManager.cpp:111
2 XUL mozilla::layers::CompositorBridgeChild::Destroy gfx/layers/ipc/CompositorBridgeChild.cpp:158
3 XUL mozilla::layers::InProcessCompositorSession::Shutdown gfx/ipc/InProcessCompositorSession.cpp:89
4 XUL nsBaseWidget::DestroyCompositor widget/nsBaseWidget.cpp:313
5 XUL nsChildView::~nsChildView widget/cocoa/nsChildView.mm:262
6 XUL nsChildView::~nsChildView widget/cocoa/nsChildView.mm:241
7 XUL <name omitted> widget/nsBaseWidget.cpp:146
8 XUL nsCocoaWindow::~nsCocoaWindow widget/cocoa/nsCocoaWindow.mm:220
9 XUL nsCocoaWindow::~nsCocoaWindow widget/cocoa/nsCocoaWindow.mm:194
We got two crashes on July 6th Nightly from 2 different installations. looks like the cause was dereferencing a null pointer
Comment 1•4 years ago
|
||
Low frequency, @jrmuizel: I don't see an obvious spot in https://searchfox.org/mozilla-central/source/gfx/layers/wr/WebRenderCommandBuilder.cpp#2607 that could cause this crash. Can you take a quick keek at this issue?
Updated•4 years ago
|
Updated•4 years ago
|
Comment 2•4 years ago
|
||
The raw crash reason for these crashes is MOZ_RELEASE_ASSERT(mWebRenderUserDatas.Count() == 0)
so they're all happening here.
Updated•4 years ago
|
Comment 4•4 years ago
|
||
Since this is Rust code the most likely reason is inlining. Unfortunately we don't have a way to deal with inlined frames yet in crash stacks.
Comment 5•4 years ago
|
||
(In reply to Gabriele Svelto [:gsvelto] from comment #4)
Since this is Rust code the most likely reason is inlining. Unfortunately we don't have a way to deal with inlined frames yet in crash stacks.
It's not Rust code but I guess inlining still applies.
Comment 6•4 years ago
|
||
Duh, yeah. I've seen WebRender on the stack and my mind immediately assumed Rust. But yeah, it applies to C++ too, the effect tends to be worse on Rust because we usually have more inlining there.
Comment 7•3 years ago
|
||
Signature died out in August. Last version with any number of crashes is 90.0.2
https://crash-stats.mozilla.org/signature/?signature=mozilla%3A%3Alayers%3A%3AWebRenderCommandBuilder%3A%3ADestroy&date=%3E%3D2021-07-04T03%3A38%3A00.000Z&date=%3C2021-10-04T03%3A38%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#graphs
Updated•3 years ago
|
Description
•