1651802 - Replace all uses of JSWindowActor willDestroy with didDestroy

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P2)

Description

[Chris Peterson [:cpeterson]]

What does frontend want from actor lifecycle methods? Can frontend listen for didDestroy in the parent process instead of willDestroy? willDestroy is not reliable.

Should the actor lifecycle methods be changed to mimic web events pageshow/pagehide plus innerwindowdestroy?

Comment 1

[Chris Peterson [:cpeterson]]

Waiting to hear from Neil Deakin in bug 1649318 which actor fields frontend code uses in willDestroy that aren't available in didDestroy. The DOM Fission team would prefer to remove willDestroy entirely (because it is an unreliable event) in favor of didDestroy.

Comment 2

[Neil Deakin]

Attachment: Bug 1651802, replace willDestroy methods in actors with didDestroy, add null-check in picture-in-picture actor which occurs if removeMouseButtonListeners while tab is closed, r=mconley

Comment 3

[Neil Deakin]

Attachment: Bug 1651802, replace willDestroy methods in conduit actors with didDestroy, as willDestroy method will be removed, r=zombie

Depends on D90737

Comment 4

[Chris Peterson [:cpeterson]]

willDestroy will be removed in bug 1662771, so we first need to switch uses of JSWindowActor willDestroy with didDestroy.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a91e5949ec8f
replace willDestroy methods in actors with didDestroy, add null-check in picture-in-picture actor which occurs if removeMouseButtonListeners while tab is closed, r=mconley
https://hg.mozilla.org/integration/autoland/rev/2a46f29c8cdd
replace willDestroy methods in conduit actors with didDestroy, as willDestroy method will be removed, r=zombie

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a91e5949ec8f
https://hg.mozilla.org/mozilla-central/rev/2a46f29c8cdd