1651867 - Permafailing tier 2 mozlint E: fixture 'root' not found

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Natalia Csoregi [:nataliaCs]]

Push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e2a60cd0189cb950d96a1cc35ee1523a1bb7dbd4&searchStr=mozlint&group_state=expanded&selectedTaskRun=PWT5faWmTBKAqulWHRIDBA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=309220511&repo=autoland

[task 2020-07-09T23:48:58.449Z] 0:34.58 _______ ERROR at setup of test_lint_excluded_file_with_no_filter[flake8] _______
[task 2020-07-09T23:48:58.449Z] 0:34.58 file /builds/worker/checkouts/gecko/tools/lint/test/test_flake8.py, line 97
[task 2020-07-09T23:48:58.449Z] 0:34.58 def test_lint_excluded_file_with_no_filter(lint, paths, config):
[task 2020-07-09T23:48:58.449Z] 0:34.58 file /builds/worker/checkouts/gecko/tools/lint/test/conftest.py, line 68
[task 2020-07-09T23:48:58.449Z] 0:34.58 @pytest.fixture(scope="module")
[task 2020-07-09T23:48:58.449Z] 0:34.58 def paths(root):
[task 2020-07-09T23:48:58.449Z] 0:34.58 E fixture 'root' not found
[task 2020-07-09T23:48:58.449Z] 0:34.58 > available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, create_temp_file, doctest_namespace, lint, monkeypatch, paths, pytestconfig, record_property, record_xml_attribute, record_xml_property, recwarn, run_setup, tmpdir, tmpdir_factory
[task 2020-07-09T23:48:58.449Z] 0:34.58 > use 'pytest --fixtures [testpath]' for help on them.
[task 2020-07-09T23:48:58.449Z] 0:34.58
[task 2020-07-09T23:48:58.449Z] 0:34.58 /builds/worker/checkouts/gecko/tools/lint/test/conftest.py:68
[task 2020-07-09T23:48:58.449Z] 0:34.58 __________ ERROR at setup of test_lint_uses_custom_extensions[flake8] __________
[task 2020-07-09T23:48:58.449Z] 0:34.58 file /builds/worker/checkouts/gecko/tools/lint/test/test_flake8.py, line 103
[task 2020-07-09T23:48:58.449Z] 0:34.58 def test_lint_uses_custom_extensions(lint, paths):
[task 2020-07-09T23:48:58.449Z] 0:34.58 file /builds/worker/checkouts/gecko/tools/lint/test/conftest.py, line 68
[task 2020-07-09T23:48:58.449Z] 0:34.58 @pytest.fixture(scope="module")
[task 2020-07-09T23:48:58.450Z] 0:34.58 def paths(root):
[task 2020-07-09T23:48:58.450Z] 0:34.58 E fixture 'root' not found
[task 2020-07-09T23:48:58.450Z] 0:34.58 > available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, create_temp_file, doctest_namespace, lint, monkeypatch, paths, pytestconfig, record_property, record_xml_attribute, record_xml_property, recwarn, run_setup, tmpdir, tmpdir_factory
[task 2020-07-09T23:48:58.450Z] 0:34.58 > use 'pytest --fixtures [testpath]' for help on them.
[task 2020-07-09T23:48:58.450Z] 0:34.58
[task 2020-07-09T23:48:58.450Z] 0:34.58 /builds/worker/checkouts/gecko/tools/lint/test/conftest.py:68
[task 2020-07-09T23:48:58.450Z] 0:34.58 =========================== 8 error in 2.71 seconds ============================
[task 2020-07-09T23:48:58.450Z] 0:34.59 Return code from mach python-test: 1
[fetches 2020-07-09T23:48:58.584Z] removing /builds/worker/fetches
[fetches 2020-07-09T23:48:58.785Z] finished
[taskcluster 2020-07-09 23:48:59.185Z] === Task Finished ===
[taskcluster 2020-07-09 23:48:59.185Z] Unsuccessful task run with exit code: 1 completed in 174.054 seconds

Comment 1

[Natalia Csoregi [:nataliaCs]]

Tom, do you have a few moments to look into this?
Thank you.

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1651867: Fix failing mozlint tests.

The root fixutre was accidentaly made not a fixture, due to a bad rebase.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1651731

Comment 5

[Intermittent Failures Robot]

10 failures in 5265 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 8
• mozilla-central: 2

Platform breakdown:

• windows10-64: 4
• linux1804-64: 5
• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1651867&startday=2020-07-06&endday=2020-07-12&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3c35c613ec4
Fix failing mozlint tests. r=ahal

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a3c35c613ec4

Comment 8

[Intermittent Failures Robot]

2 failures in 4014 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 2

Platform breakdown:

• windows10-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1651867&startday=2020-07-13&endday=2020-07-19&tree=all

Comment 9

[Mark Banner (:standard8)]

Clearing obsolete NI.