1651947 - Figure out how to scale down print preview

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P1)

Description

[Jonathan Watt [:jwatt]]

The new printing UI puts print preview in a doorhander, which is narrower than the full tab print preview that we currently have. mstriemer mentioned in a call that the reduced width causes the preview document to get horizontal scrollbars, which is obviously horrible.

We should figure out how to coordinate scaling of the print preview document so that it does not scroll horizontally. ComputePageTransform is probably a good place to start looking.

Comment 1

[Daniel Holbert [:dholbert] (PTO until 2/24)]

(Somewhat relatedly, we'll also need to scale down each tiny-page in the "pages per sheet" visualization & printed output. And then also scale down the sheet itself, to fit into doorhanger per comment 0. Possibly some code-sharing opportunities.)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Poking at this. This is different from bug 1631452 in the sense that this should have no layout effect on the page (and that's great because or incremental reflow setup in print preview just sucks).

I have a patch that almost does it, on top of Mark's patch. It abuses the print preview scale we already apply in the page sequence frame. I think that's the way to go, since it's both trivial and gets us the desired effect.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1651947 - Scale the page sequence in print preview so that pages don't overflow the viewport horizontally. r=dholbert

This seems to almost do the trick, only some tweaks missing (the
overflow area gets too big and we show scrollbars), and we don't account
for the pages' horizontal margin. All that is fixable of course and will
look after lunch.

This requires flexing the browser element so that the viewport size of
the print preview document changes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bed71c154785
Scale the page sequence in print preview so that pages don't overflow the viewport horizontally. r=dholbert

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/bed71c154785