Closed Bug 1652266 Opened 4 years ago Closed 4 years ago

Improve blur with software WebRender

Categories

(Core :: Graphics: WebRender, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: jrmuizel, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Doing blur the same way we do it on the GPU is a bad idea. The current GPU blur relies heavily on texture sampling which is the thing that SWGL is the worst at.

See https://share.firefox.dev/329F4hM for an example profile where blur is the bottleneck.
This is from "scrolling old reddit with subreddit styles off"

Blocks: sw-wr-perf
Severity: -- → S3
Priority: -- → P3
Depends on: 1664479

https://www.bostonherald.com/2020/10/30/majority-of-massachusetts-coronavirus-clusters-are-from-households/ if you move down to the "Top Articles" carousel seems to be a reasonably decent test page. It spends almost all its time in the blur shader...

Blocks: 1674661
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8cf9fe4e2463 implement Gaussian blur fast-path for SWGL. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
Regressions: 1710325
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: