1664479 - Optimize cs_blur shader for SWGL

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Lee Salzman [:lsalzman]]

The cs_blur shader contains a number of things that could easily be precalculated in the vertex shader to reduce the number of operations and branching. A lot of these show up in the profiler for SWGL, such as the sigma math at the beginning of the fragment shader to initialize the gauss coefficients.

Fixing this should make it faster for both HW and SWGL cases. This may obviate the need to do more intensive SWGL optimize of blurring until later...

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: Bug 1664479 - optimize cs_blur shader for SWGL. r?gw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fff9280e69f3
optimize cs_blur shader for SWGL. r=gw

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset fff9280e69f3 (bug 1664479) for causing bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Z0rs2544QoejFKFHkYnvuA.0&searchStr=windows%2C2012%2Cbuild&fromchange=65196da3227eb77b226bdcf5d229a5b71fe4ef1a&tochange=4cf4f82f9dde27681c391d4c133c9ea753d0209f

Backout link: https://hg.mozilla.org/integration/autoland/rev/4cf4f82f9dde27681c391d4c133c9ea753d0209f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315589142&repo=autoland&lineNumber=52690

...
[task 2020-09-14T02:01:16.772Z] 02:01:16     INFO -  [style 0.0.1] cargo:rerun-if-changed=/builds/worker/workspace/obj-build/dist/include/nsCharTraits.h
[task 2020-09-14T02:01:16.772Z] 02:01:16     INFO -  [style 0.0.1] cargo:rerun-if-changed=/builds/worker/workspace/obj-build/dist/include/nsTDependentString.h
[task 2020-09-14T02:01:16.772Z] 02:01:16     INFO -  error: build failed
[task 2020-09-14T02:01:16.772Z] 02:01:16    ERROR -  make[4]: *** [/builds/worker/checkouts/gecko/config/makefiles/rust.mk:303: force-cargo-library-build] Error 101
[task 2020-09-14T02:01:16.772Z] 02:01:16     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/toolkit/library/gtest/rust'
[task 2020-09-14T02:01:16.772Z] 02:01:16    ERROR -  make[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: toolkit/library/gtest/rust/target] Error 2
[task 2020-09-14T02:01:16.772Z] 02:01:16     INFO -  make[3]: *** Waiting for unfinished jobs....

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca66708049b8
optimize cs_blur shader for SWGL. r=gw

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ca66708049b8