Closed Bug 16523 Opened 26 years ago Closed 26 years ago

[blocker]nsTextEditRules::DidDoAction returns NS_ERROR_FAILURE for actions not performed by rules system

Categories

(Core :: DOM: Editor, defect, P1)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: cmanske, Assigned: mozeditor)

References

Details

Because nsTextEditRules::DidDoAction returns NS_ERROR_FAILURE for cases not included in the transaction switch (info->action) block, actions such as nsHTMLEditor::InsertList() and nsHTMLEditor::InsertElement() and nsHTMLEditor::InsertElement() return failure, which really isn't true. The default return value should be NS_OK. Joe: If the issue is simply changing the default return type, I'll be happy to make this change. This bug is causing lots of UI actions to appear to fail.
*** Bug 16321 has been marked as a duplicate of this bug. ***
*** Bug 16689 has been marked as a duplicate of this bug. ***
*** Bug 16690 has been marked as a duplicate of this bug. ***
*** Bug 16790 has been marked as a duplicate of this bug. ***
accepting/m11
Severity: normal → blocker
Priority: P3 → P1
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
I fixed this last week and forgot to clear the bug Verification is that you can insert objects like hlines, links, etc. and not see a JavaScript exception error in the debug output window.
need help verifying this one...Charley or Joe??? thanks!
I don't see error messages in JS.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.