16690 - image dlog JS error on open

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Kathleen :Brade]

with today's build, when I try to insert an image, I get the following error when
loading the dialog:

JavaScript Error: syntax error
URL: chrome://editor/content/EdImageProps.js
LineNo: 574
Line text: '    else
'

Comment 1

[Charles Manske]

I put exception handling in the image dialog Java Script so the image should
be inserted. This exception is "bogus" because of bug 16523.
If the image is not showing up, that is a different problem in image layout.
Please -- no more bugs on insert object "exceptions" until 16523 is fixed!

*** This bug has been marked as a duplicate of 16523 ***

Comment 2

[Kathleen :Brade]

I don't understand how this can be a duplicate of a bug within rules.  This is a
JavaScript syntax error.  Reopening.  Please explain if you feel it is a
duplicate.

Comment 3

[Charles Manske]

Oops! Acted too soon and confused this with Sujays bug that looked similar.

Comment 4

[Charles Manske]

I'm not seeing this problem today. Kathy?

Comment 5

[Kathleen :Brade]

Yes, I still see this problem on Mac:

JavaScript Error: syntax error
URL: chrome://editor/content/EdImageProps.js
LineNo: 574
Line text: '     else
'

Comment 6

[Kathleen :Brade]

looking at the code, I'd say you are missing a '}'

Comment 7

[rubydoo123]

pushing this out till next week

Comment 8

[Kathleen :Brade]

resolving as fixed; I saw the diff from Charley at some point.

Comment 9

[Kathleen :Brade]

verifying since I don't see that error anymore