1652384 - rich editor add some new table column，but new cell's border-bottom is none

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[1017866168]

Attachment: [e-mail]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.16 Safari/537.36

Steps to reproduce:

1. open url: https://dev.myones.net/wiki/master/#/team/WPMrXC1s/space/ED1tsNHs/page/KwHheQ36/edit
2. account: [e-mail] password: 12345678lv
3. insert table， select a cell, add many new colum

Actual results:

new cell's border-bottom is none
on chrome is Ok.

Expected results:

new cell's border-bottom is normal

Comment 1

[Peter Magyari (Desktop QA)]

Hi!

I wasn't able to reproduce your issue on Firefox Nightly 80.0a1 or Firefox 78.0.2.

Adding new columns worked correctly on my end.

Could you check if this also happens to you while in safe-mode? Here is a link that can help you with that:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode#w_how-to-start-firefox-in-safe-mode

If it still does, try making a new profile and check again. Here's how:
https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles#w_start-the-profile-manager-when-firefox-is-closed

Thanks!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Mats Palmgren (inactive)]

I can't reproduce the bug in Nightly on Linux, FWIW.

Comment 4

[1017866168]

(In reply to Mats Palmgren (:mats) from comment #3)

I can't reproduce the bug in Nightly on Linux, FWIW.

I am author.
Sorry, because it’s urgent, so I skipped this question with compatible CSS syntax, I will provide a new address

https://dev.myones.net/wiki/FE005/#/team/WPMrXC1s/space/ED1tsNHs/page/KwHheQ36/edit

Comment 5

[1017866168]

(In reply to Peter_M from comment #1)

Hi!

I wasn't able to reproduce your issue on Firefox Nightly 80.0a1 or Firefox 78.0.2.

Adding new columns worked correctly on my end.

Could you check if this also happens to you while in safe-mode? Here is a link that can help you with that:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode#w_how-to-start-firefox-in-safe-mode

If it still does, try making a new profile and check again. Here's how:
https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles#w_start-the-profile-manager-when-firefox-is-closed

Thanks!

I am author.
Sorry, because it’s urgent, so I skipped this question with compatible CSS syntax, I will provide a new address

https://dev.myones.net/wiki/FE005/#/team/WPMrXC1s/space/ED1tsNHs/page/KwHheQ36/edit

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: not-very-reduced test-case.

Thanks, I can reproduce that. Here's a test-case based on your website (didn't bother reducing much though)

Comment 7

[Emilio Cobos Álvarez (:emilio)]

It seems we don't correctly recompute collapsed borders in this case somehow.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Test-case without modern JS-things (for bisection)

It's a very old bug :)

Comment 9

[Emilio Cobos Álvarez (:emilio)]

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=854aabf544d4&tochange=bc48009a6bbb

Bug 460637, almost surely.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Fully reduced test-case

A bit surprised that the colgroup is needed.

Comment 11

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1652384 - When inserting a col frame, invalidate all subsequent column BC borders. r=mats

This is the same fix as the fix for bug 711359, basically... We don't
shift the damage area otherwise which means that we would incorrectly
miss computing some borders.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7916b0f71d69
When inserting a col frame, invalidate all subsequent column BC borders. r=mats

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24761 for changes under testing/web-platform/tests

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7916b0f71d69

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot