1652445 - Use root node resource for all frames navigations

Status: RESOLVED FIXED

(DevTools :: Inspector, task, P3)

Description

[Julian Descottes [:jdescottes]]

Currently, the root-node resource is only used when the topmost level of a given target changes.

If a target contains same-process frames, a navigation will be handled in the same it was pre-fission: we emit two fake mutations: "documentUnload" and "frameLoad" (as well as additional fake "childList" mutations with empty added and removed arrays).

This means we need to maintain two codepaths for similar tasks: one using the root node resource, one using the mutations.

At some point we should get one target per window global, which would solve the inconsistency. But it might be better to address this sooner.

Comment 1

[Julian Descottes [:jdescottes]]

Blocking Bug 1644190. I tried to start migrating the root node fully to the server, but the mix of mutations and events in the Walker actor at the moment makes it difficult to reason about. Will be much easier if this is addressed first.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1652445 - Rename WalkerActor _ref method and _refMap property

Optional cleanup, but the _ref method name makes it hard to understand when we are reading the actor cache vs creating new actors.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1652445 - Use root node resource to detect navigation for all frames

Depends on D84972

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1652445 - Fix highlighters overlay to react to frame navigation

Depends on D84973

Comment 5

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c).

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1652445 - Remove outdated traits from NodeActor

Depends on D84972

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1652445 - Remove backward compatibility code for newRoot mutations

Depends on D85597

newRoot mutations are no longer emitted by any server we support, we can remove the corresponding client code.

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1652445 - Remove skipped & outdated test browser_inspector-mutations-frameload.js

Depends on D85598

This test relies on mutations which are no longer emitted for most navigations and which will no longer be emitted at all with the next patches.
It has been disabled for 9 months and should be removed.

Comment 9

[Julian Descottes [:jdescottes]]

Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd8f66d6f25531927c721c75d64a95da008bbc06

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a99f92bd4815
Rename WalkerActor _ref method and _refMap property r=gl
https://hg.mozilla.org/integration/autoland/rev/24166ec8744b
Remove outdated traits from NodeActor r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/a7435c1518d9
Remove backward compatibility code for newRoot mutations r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/a1d88e105644
Remove skipped & outdated test browser_inspector-mutations-frameload.js r=ochameau
https://hg.mozilla.org/integration/autoland/rev/54d7c064365e
Use root node resource to detect navigation for all frames r=rcaliman,ochameau
https://hg.mozilla.org/integration/autoland/rev/4d51d99a85a4
Fix highlighters overlay to react to frame navigation r=rcaliman

Comment 11

[Julian Descottes [:jdescottes]]

Latest try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1236bdc2b3b9262c82a330587a9d1be59463fd5d

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a99f92bd4815
https://hg.mozilla.org/mozilla-central/rev/24166ec8744b
https://hg.mozilla.org/mozilla-central/rev/a7435c1518d9
https://hg.mozilla.org/mozilla-central/rev/a1d88e105644
https://hg.mozilla.org/mozilla-central/rev/54d7c064365e
https://hg.mozilla.org/mozilla-central/rev/4d51d99a85a4