Closed Bug 1628473 Opened 6 months ago Closed 3 months ago

Update markup view when a remoted iframe navigates or reload

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(Fission Milestone:M6c, firefox80 fixed)

RESOLVED FIXED
Firefox 80
Fission Milestone M6c
Tracking Status
firefox80 --- fixed

People

(Reporter: ochameau, Assigned: jdescottes)

References

(Blocks 3 open bugs)

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(5 files, 1 obsolete file)

Bug 1593937 helps knowing about navigation and reload for remoted iframes.
A new Target will be created for each navigation/reload. For each WindowGlobal.
But bug 1593937 did not address markup view updates.
The existing codebase probably relies on mutation RDP event in order to update it and we probably do not detect frame navigations correctly from the actor side.

Priority: -- → P3
Whiteboard: dt-fission-m2-mvp
Priority: P3 → P2

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Fission Milestone: --- → M6

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Fission Milestone: M6 → M6c
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Attachment #9156685 - Attachment description: Bug 1628473 - Move assertMarkupViewAsTree helper to the main inspector head.js → Bug 1628473 - Move test helpers from markup head.js to the main inspector head.js
Blocks: 1644190
Attachment #9156688 - Attachment is obsolete: true
Blocks: 1652414
Blocks: 1652419
Blocks: 1652445
Attachment #9156685 - Attachment description: Bug 1628473 - Move test helpers from markup head.js to the main inspector head.js → Bug 1628473 - Move test helpers from markup head.js to inspector shared-head.js
Attachment #9156685 - Attachment description: Bug 1628473 - Move test helpers from markup head.js to inspector shared-head.js → Bug 1628473 - Move test helpers from markup head.js to inspector head.js
No longer blocks: 1652414
See Also: → 1652414
Attachment #9156687 - Attachment description: Bug 1628473 - Emit childlist mutation when receiving a non toplevel root node → Bug 1628473 - Update the markup view when a remote frame navigates
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c77e99cb16bf
Remove watchRootNode trait r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/24b1aa76604c
Move test helpers from markup head.js to inspector head.js r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/57e7d63c4376
Add test for remote frame navigation r=rcaliman,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/5617ce535889
Update the markup view when a remote frame navigates r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/835be8972a90
Stop relying on documentUnload mutation in browser_toolbox_window_reload_target.js r=rcaliman
Blocks: 1653521
Regressions: 1653401
You need to log in before you can comment on or make changes to this bug.