1628473 - Update markup view when a remoted iframe navigates or reload

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Alexandre Poirot [:ochameau]]

Bug 1593937 helps knowing about navigation and reload for remoted iframes.
A new Target will be created for each navigation/reload. For each WindowGlobal.
But bug 1593937 did not address markup view updates.
The existing codebase probably relies on mutation RDP event in order to update it and we probably do not detect frame navigations correctly from the actor side.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking Fission DevTools bugs for Fission Nightly (M6) milestone

Comment 2

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c)

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1628473 - Move test helpers from markup head.js to inspector head.js

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1628473 - Add test for remote frame navigation

Depends on D79674

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1628473 - Update the markup view when a remote frame navigates

Depends on D79675

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1628473 - Optional: use onDestroyed to release destroyed root node resources

Depends on D79676

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1628473 - Remove watchRootNode trait

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1628473 - Stop relying on documentUnload mutation in browser_toolbox_window_reload_target.js

Depends on D79676

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c77e99cb16bf
Remove watchRootNode trait r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/24b1aa76604c
Move test helpers from markup head.js to inspector head.js r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/57e7d63c4376
Add test for remote frame navigation r=rcaliman,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/5617ce535889
Update the markup view when a remote frame navigates r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/835be8972a90
Stop relying on documentUnload mutation in browser_toolbox_window_reload_target.js r=rcaliman

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/c77e99cb16bf
https://hg.mozilla.org/mozilla-central/rev/24b1aa76604c
https://hg.mozilla.org/mozilla-central/rev/57e7d63c4376
https://hg.mozilla.org/mozilla-central/rev/5617ce535889
https://hg.mozilla.org/mozilla-central/rev/835be8972a90