1652463 - Failed to create top level IPC between socket process and parent process on windows

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Kershaw Chang [:kershaw]]

STR:

1. set network.http.network_access_on_socket_process.enabled to true.
2. Restrart firefox and access any https site.

Disabling sandbox by setting MOZ_DISABLE_SOCKET_PROCESS_SANDBOX=1 can fix this issue, so this should be related to sandboxing.

[Socket 12700, Socket Thread] WARNING: failed to create pipe: 5: file c:/work/mozilla-central/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 236
[Socket 12700, Socket Thread] WARNING: Unable to create pipe named "12700.0.728279352\355809996" in server mode.: file c:/work/mozilla-central/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 68
[Socket 12700, Socket Thread] WARNING: failed to create pipe: 2: file c:/work/mozilla-central/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 236

###!!! [Child][MessageChannel] Error: (msgtype=0x60056,name=PBackground::Msg_PVerifySSLServerCertConstructor) Channel error: cannot send/recv

Hit MOZ_CRASH(MsgDropped: Channel error: cannot send/recv) at c:/work/mozilla-central/ipc/glue/BackgroundChildImpl.cpp:153
[Parent 12336, Gecko_IOThread] ###!!! ABORT: file c:/work/mozilla-central/ipc/chromium/src/base/message_pump_win.cc, line 402

Comment 1

[Bob Owen (:bobowen)]

Attachment: Bug 1652463: Add rule to allow socket process to create server side of our IPC pipes. r=handyman!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afc05ca167e7
Add rule to allow socket process to create server side of our IPC pipes. r=handyman

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/afc05ca167e7

Comment 4

[Alexandru Michis [:malexandru]]

Backed out changeset afc05ca167e7 (Bug 1652463) for causing mochitest media spi failures.

Failures in test_peerConnection_asymmetricIsolation.html:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=310706513&repo=autoland&lineNumber=4435

These have been tracked in Bug 1227386 and the increase in failures can be seen in
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?startday=2020-07-15&endday=2020-07-22&tree=trunk&bug=1227386

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33ebacea47a9
Backed out changeset afc05ca167e7 for causing mochitest media spi failures.

Comment 6

[Bob Owen (:bobowen)]

kershaw - this caused bug 1227386 to become a perma-fail (see bug 1227386 comment 47 from bwc).

It seems unlikely that this change in itself would cause an issue.
The only thing I can think of is that something is now working that was blocked before, causing some sort of knock-on effect.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bobowen, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 8

[Bob Owen (:bobowen)]

Waiting for information from :kershaw.

Comment 9

[Kershaw Chang [:kershaw]]

It seems this test is no longer failed with this patch.
https://treeherder.mozilla.org/jobs?repo=try&revision=fb49873352221bc6b992bdc75a38c53c913e89de
Bug 1227386 also shows the last failure of this test was 4 months ago.

Bob, could you try to re-land this patch? Thanks.

Comment 10

[Bob Owen (:bobowen)]

(In reply to Kershaw Chang [:kershaw] from comment #9)

It seems this test is no longer failed with this patch.
https://treeherder.mozilla.org/jobs?repo=try&revision=fb49873352221bc6b992bdc75a38c53c913e89de
Bug 1227386 also shows the last failure of this test was 4 months ago.

Bob, could you try to re-land this patch? Thanks.

Thanks for re-testing this, should be on autoland soon ...

Comment 11

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b9abaf976608

Comment 12

[Natalia Csoregi [:nataliaCs]]

Backed out as per request.

• backout: https://hg.mozilla.org/integration/autoland/rev/57aa1b41c49b2ae6483b631f5bcc1e4c80c712ca

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout go merged to central: https://hg.mozilla.org/mozilla-central/rev/57aa1b41c49b

Comment 14

[Kershaw Chang [:kershaw]]

May I ask why this was backed out?
Thanks.

Comment 15

[Bob Owen (:bobowen)]

Turns out the work in bug 1713148 should have fixed this.