1713148 - Use the message router for all channels

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Nika Layzell [:nika] (ni? for response)]

Build on top of the work in bug 1706374 to also use these multiplexed channels for other channels between processes such as PBackground.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1713148 - Part 1: Expose UserMessageEvent to WillBeRoutedExternally,

This is used because, unlike in Mojo, we cannot get from the IPC::Message
object to its enclosing UserMessageEvent object to attach more ports to it, and
this extra parameter makes that easy to do.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1713148 - Part 2: Support port attachments on IPC messages,

These port attachments are stored directly on the IPC::Message until the
message is ready to be routed to another process, at which point they will be
attached to the port in WillBeRoutedExternally. When the message is then
received on the other side, the ports will be re-extracted from the
UserMessageEvent before it is discarded and re-added to the IPC::Message so
that serializers only need to interact directly with the IPC::Message type.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1713148 - Part 3: Use ports for Endpoint-created actors,

This adjusts how all actors created using Endpoint behave so that they now
use ports instead of creating a unique native channel connection between each
pair of processes.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1713148 - Part 4: Remove ProcessLink,

After the changes in part 3, this type is now dead code and can be fully
removed.

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1713148 - Part 5: Remove ThreadLink,

This removes the last form of unique link between two MessageChannels so that
all MessageChannels communicate using PortLink, as it is fairly straightforward
to use PortLink to communicate between two threads in-process.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/677e1ee99bb2
Part 1: Expose UserMessageEvent to WillBeRoutedExternally, r=handyman
https://hg.mozilla.org/integration/autoland/rev/2da57973ed55
Part 2: Support port attachments on IPC messages, r=handyman
https://hg.mozilla.org/integration/autoland/rev/f2e5309c914c
Part 3: Use ports for Endpoint-created actors, r=handyman
https://hg.mozilla.org/integration/autoland/rev/fd8523d5126e
Part 4: Remove ProcessLink, r=handyman
https://hg.mozilla.org/integration/autoland/rev/ea469eaa54ca
Part 5: Remove ThreadLink, r=handyman

Comment 7

[Atila Butkovits]

Backed out for causing build bustages on MessageChannel.cpp.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b900d99a2ae8f0902d0679b97ba311ec5f487fe7

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=ea469eaa54ca1fa9eca22e97e066743a5c861022&selectedTaskRun=Lx_mIB9HRbO004Kr3uvhlg.0&searchStr=Linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2CBb

Failure log: https://treeherder.mozilla.org/logviewer?job_id=343447057&repo=autoland&lineNumber=39808

Comment 8

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1713148 - Part 6: Release sChannelCountMutex before calling report callback,

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40133c11821d
Part 1: Expose UserMessageEvent to WillBeRoutedExternally, r=handyman
https://hg.mozilla.org/integration/autoland/rev/04abcc40b9ff
Part 2: Support port attachments on IPC messages, r=handyman
https://hg.mozilla.org/integration/autoland/rev/2a526c6c4d9d
Part 3: Use ports for Endpoint-created actors, r=handyman
https://hg.mozilla.org/integration/autoland/rev/c07634493a6f
Part 4: Remove ProcessLink, r=handyman
https://hg.mozilla.org/integration/autoland/rev/b67473c8e44e
Part 5: Remove ThreadLink, r=handyman
https://hg.mozilla.org/integration/autoland/rev/ad6887dc2abf
Part 6: Release sChannelCountMutex before calling report callback, r=handyman

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/40133c11821d
https://hg.mozilla.org/mozilla-central/rev/04abcc40b9ff
https://hg.mozilla.org/mozilla-central/rev/2a526c6c4d9d
https://hg.mozilla.org/mozilla-central/rev/c07634493a6f
https://hg.mozilla.org/mozilla-central/rev/b67473c8e44e
https://hg.mozilla.org/mozilla-central/rev/ad6887dc2abf