Closed Bug 1652561 Opened 2 years ago Closed 2 years ago

Remove Win32k usage from nsLookAndFeel::GetFontImpl()

Categories

(Core :: Widget: Win32, task)

x86_64
Windows
task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: cmartin, Assigned: cmartin)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Currently, this API runs in content process and makes calls to ::GetDC() and SystemParametersInfo(). This will need to be changed for Win32k lockdown

Currently, this code creates large and non-trivial classes that will be
difficult to remote. This change creates an intermediate stage where a simple
struct is returned from a function and then used to initialize these
more complex classes.

It is this simple struct that will be remoted across processes

Content processes will now receive cached values for GetFontImpl() from the
parent process during initialization and whenever the theme changes.

This eliminates the use of several Win32k calls in content.

Depends on D83405

Pushed by cmartin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c8b7db8138c
Refactor nsLookAndFeel::GetFontImpl() to prepare for remoting r=jmathies
https://hg.mozilla.org/integration/autoland/rev/2184eaae2299
Remote Win32k calls in nsLookAndFeel::GetFontImpl() r=emilio,geckoview-reviewers,agi,froydnj
You need to log in before you can comment on or make changes to this bug.