1652561 - Remove Win32k usage from nsLookAndFeel::GetFontImpl()

Status: RESOLVED FIXED

(Core :: Widget: Win32, task)

Description

[Chris Martin [:cmartin]]

Currently, this API runs in content process and makes calls to ::GetDC() and SystemParametersInfo(). This will need to be changed for Win32k lockdown

Comment 1

[Chris Martin [:cmartin]]

Attachment: Bug 1652561 - Refactor nsLookAndFeel::GetFontImpl() to prepare for remoting

Currently, this code creates large and non-trivial classes that will be
difficult to remote. This change creates an intermediate stage where a simple
struct is returned from a function and then used to initialize these
more complex classes.

It is this simple struct that will be remoted across processes

Comment 2

[Chris Martin [:cmartin]]

Attachment: Bug 1652561 - Remote Win32k calls in nsLookAndFeel::GetFontImpl()

Content processes will now receive cached values for GetFontImpl() from the
parent process during initialization and whenever the theme changes.

This eliminates the use of several Win32k calls in content.

Depends on D83405

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c8b7db8138c
Refactor nsLookAndFeel::GetFontImpl() to prepare for remoting r=jmathies
https://hg.mozilla.org/integration/autoland/rev/2184eaae2299
Remote Win32k calls in nsLookAndFeel::GetFontImpl() r=emilio,geckoview-reviewers,agi,froydnj

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5c8b7db8138c
https://hg.mozilla.org/mozilla-central/rev/2184eaae2299