Change LookAndFeelCache to use IPDL struct serialization codegen
Categories
(Core :: Widget: Win32, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: cmartin, Assigned: jld)
References
Details
Attachments
(2 files)
In Bug 1652561, I added a new struct extending LookAndFeelInt with font info. During this time, :jld suggested that we should be using the automatic serialization code generator in IPDL to pass all these structs through IPC. Seems like a good idea!
|
Assignee | |
Comment 1•5 years ago
|
||
Taking the bug as discussed on Matrix, because I have a patch — I was prototyping a solution for bug 1470983, and merging it with bug 1652561 give me two mostly equivalent definitions of “system font info for IPC” so I combined them.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
The IPDL compiler searches for files in an include path made up of every
directory with any IPDL_SOURCES in it, which means that distinct files
shouldn't have the same name or, failing that, need to be set up so they
won't accidentally conflict. See bug 1657712 for details.
In widget/, the PCompositorWidget and PlatformWidgetTypes files are
overridden on some OSes; this patch moves the general-case versions into
their own directory, so that it's possible to use the widget/ toplevel
directory for non-platform-specific IPDL without causing a filename
conflict.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Aside from automating boilerplate, this will allow reusing some of these
structs for full LookAndFeel remoting in bug 1470983.
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1a89b3ac4993
https://hg.mozilla.org/mozilla-central/rev/cadd17ae918b
Description
•