1652575 - Whitelisted email addresses for remote content are no longer shown in preferences

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Mark Banner (:standard8)]

STR

1. Receive an email with remote content
2. Select to always allow remote content from that email address.
3. Go into Preferences -> Privacy & Security.
4. Click the Exceptions button next to "Allow remote content in messages"

Actual Results

The list is empty

Expected Results

The email added in step 2 is listed.

As a result, I can't manage the list of emails I've already whitelisted.

Tested in 78.0b4 on Mac.

Comment 1

[Thomas D. (:thomas8)]

Confirmed also for 78.0b4 (32-bit) on Windows

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=9f4a9f7ce10651f40e6788c3c1d648f4fb99d9dd&tochange=56288941d6185b1a281af725996db62324e8c79c
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8b62adf33598b50a04bc44eec167827dd9ede178&tochange=8b62adf33598b50a04bc44eec167827dd9ede178

Regressed by: Bug 1615501

Comment 3

[Thomas D. (:thomas8)]

Mark, anything in error console?

Comment 4

[Mark Banner (:standard8)]

Nothing in the error console.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: bug1652575_imageperms_regression.patch

Comment 6

[Khushil Mistry [:khushil324]]

Comment on attachment 9164677 [details] [diff] [review]
bug1652575_imageperms_regression.patch

Review of attachment 9164677 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=khushil.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/41aad38b0fa9
make whitelisted email addresses for remote content show up (broken due to missed async adjustments). r=khushil

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9164677 [details] [diff] [review]
bug1652575_imageperms_regression.patch

[Approval Request Comment]
Regression caused by (bug #): 1615501
User impact if declined: This is a feature that should just work.

Comment 9

[Jorg K (CEST = GMT+2)]

Agreed. And the developer and/or reviewer should have requested uplift and not left it to someone else to track down missing requests.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9164677 [details] [diff] [review]
bug1652575_imageperms_regression.patch

[Triage Comment]
Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.1.1:
https://hg.mozilla.org/releases/comm-esr78/rev/ed455ce362ed