1652703 - input-container added to id instead of class

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[John Bieling (:TbSync)]

At

https://searchfox.org/comm-central/source/mail/components/addrbook/content/abCard.inc.xhtml#170
https://searchfox.org/comm-central/source/mail/components/addrbook/content/abCard.inc.xhtml#181
https://searchfox.org/comm-central/source/mail/components/addrbook/content/abCard.inc.xhtml#192
https://searchfox.org/comm-central/source/mail/components/addrbook/content/abCard.inc.xhtml#203
https://searchfox.org/comm-central/source/mail/components/addrbook/content/abCard.inc.xhtml#214

input-container was added to the id instead to the class.

Comment 1

[John Bieling (:TbSync)]

It also looks like the hbox structure is a bit different: All the other input fields have an extra hbox around the input itself, which has class="input-container" and not the outer hbox as with these 5 elements.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: 1652703-ab-class.diff

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9163536 [details] [diff] [review]
1652703-ab-class.diff

Thanks.
Maybe you could improve the commit message a bit. And when you're on it, then use "Paenglab"

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1652703-ab-class.diff

Comment 5

[Alessandro Castellani [:aleca]]

Comment on attachment 9163544 [details] [diff] [review]
1652703-ab-class.diff

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Wrong HTML structure in the address book edit card, which may lead to a broken layout
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): Very low

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b79b38d08bf5
Fix wrong input-container structure in AddressBook edit dialog. r=Paenglab

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9163544 [details] [diff] [review]
1652703-ab-class.diff

Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9163544 [details] [diff] [review]
1652703-ab-class.diff

[Triage Comment]
This has not been on a beta yet from what I can tell, so approving for 79b2.

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 78.0.1:
https://hg.mozilla.org/releases/comm-esr78/rev/25debbf1c762

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 79.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/c4124873bf8f1b9f20602e234c3a4e03e67780ab