Closed Bug 1652703 Opened 5 years ago Closed 5 years ago

input-container added to id instead of class

Categories

(Thunderbird :: Address Book, defect)

Product:
Thunderbird
Component:
Address Book
Type:
defect

Tracking

(thunderbird_esr78 fixed, thunderbird79 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 80.0
Tracking Flags:
Tracking Status
thunderbird_esr78 --- fixed
thunderbird79 --- fixed

People

(Reporter: TbSync, Assigned: aleca)

References

Details

Attachments

(1 file, 1 obsolete file)

1652703-ab-class.diff
5.50 KB, patch
aleca
: review+
rjl
: approval-comm-beta+
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review

It also looks like the hbox structure is a bit different: All the other input fields have an extra hbox around the input itself, which has class="input-container" and not the outer hbox as with these 5 elements.

Blocks: tb78found
Assignee: nobody → alessandro
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached patch 1652703-ab-class.diff (obsolete) — — Splinter Review
Attachment #9163536 - Flags: review?(richard.marti)
See Also: → 1652256
Comment on attachment 9163536 [details] [diff] [review] 1652703-ab-class.diff Thanks. Maybe you could improve the commit message a bit. And when you're on it, then use "Paenglab"
Attachment #9163536 - Flags: review?(richard.marti) → review+
Attachment #9163536 - Attachment is obsolete: true
Attachment #9163544 - Flags: review+
Keywords: checkin-needed-tb
Comment on attachment 9163544 [details] [diff] [review] 1652703-ab-class.diff [Approval Request Comment] Regression caused by (bug #): User impact if declined: Wrong HTML structure in the address book edit card, which may lead to a broken layout Testing completed (on c-c, etc.): soon on c-c Risk to taking this patch (and alternatives if risky): Very low
Attachment #9163544 - Flags: approval-comm-esr78?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/b79b38d08bf5
Fix wrong input-container structure in AddressBook edit dialog. r=Paenglab

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 80.0
Comment on attachment 9163544 [details] [diff] [review] 1652703-ab-class.diff Approved for esr78
Attachment #9163544 - Flags: approval-comm-esr78? → approval-comm-esr78+
Comment on attachment 9163544 [details] [diff] [review] 1652703-ab-class.diff [Triage Comment] This has not been on a beta yet from what I can tell, so approving for 79b2.
Attachment #9163544 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: