1652786 - mach bootstrap: AttributeError: 'dict' object has no attribute 'strict'

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This is on ubuntu 20.04

Error running mach:

    ['artifact', 'toolchain', '--bootstrap', '--from-build', 'linux64-node']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file artifact| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'dict' object has no attribute 'strict'

  File "/home/dblohm7/src/mc2/python/mozbuild/mozbuild/artifact_commands.py", line 315, in artifact_toolchain
    toolchains = load_tasks_for_kind(params, 'toolchain', root_dir=root_dir)
  File "/home/dblohm7/src/mc2/taskcluster/taskgraph/generator.py", line 427, in load_tasks_for_kind
    for task in tgg.full_task_set
  File "/home/dblohm7/src/mc2/taskcluster/taskgraph/generator.py", line 151, in full_task_set
    return self._run_until('full_task_set')
  File "/home/dblohm7/src/mc2/taskcluster/taskgraph/generator.py", line 372, in _run_until
    k, v = next(self._run)
  File "/home/dblohm7/src/mc2/taskcluster/taskgraph/generator.py", line 241, in _run
    self.verify_parameters(parameters)
  File "/home/dblohm7/src/mc2/taskcluster/taskgraph/generator.py", line 379, in verify_parameters
    if not parameters.strict:
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-C to quit
Error running mach:

    ['bootstrap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file bootstrap| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

subprocess.CalledProcessError: Command '['/usr/bin/python3', '/home/dblohm7/src/mc2/mach', 'artifact', 'toolchain', '--bootstrap', '--from-build', 'linux64-node']' returned non-zero exit status 1.

  File "/home/dblohm7/src/mc2/python/mozboot/mozboot/mach_commands.py", line 46, in bootstrap
    bootstrapper.bootstrap()
  File "/home/dblohm7/src/mc2/python/mozboot/mozboot/bootstrap.py", line 570, in bootstrap
    self.maybe_install_private_packages_or_exit(state_dir,
  File "/home/dblohm7/src/mc2/python/mozboot/mozboot/bootstrap.py", line 420, in maybe_install_private_packages_or_exit
    self.instance.ensure_node_packages(state_dir, checkout_root)
  File "/home/dblohm7/src/mc2/python/mozboot/mozboot/linux_common.py", line 102, in ensure_node_packages
    self.install_toolchain_artifact(state_dir, checkout_root, node.LINUX)
  File "/home/dblohm7/src/mc2/python/mozboot/mozboot/base.py", line 360, in install_toolchain_artifact
    subprocess.check_call(cmd, cwd=state_dir)
  File "/usr/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)

Comment 1

[Michael Froman [:mjf]]

I am seeing it on 18.04 and macOS as well.

Comment 2

[Michael Froman [:mjf]]

Appears to be regressed by 8c0e953f215b: "No bug: [taskgraph] Make verify_test_packaging handle --target-kind gracefully; r=Callek"

Comment 3

[Michael Froman [:mjf]]

If I apply the fix for Bug 1652759, I can successfully complete './mach bootstrap' on ab433cee6227, but with the same patch applied 8c0e953f215b fails.

Comment 4

[Tom Prince [:tomprince]]

Attachment: Bug 1652786: [taskgraph] Fix parameter handling `load_tasks_for_kind; r?Callek

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/d31bc01c978f
[taskgraph] Fix parameter handling `load_tasks_for_kind; r=Callek a=Callek

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d31bc01c978f

Comment 7

[Alexandru Michis [:malexandru]]

Autoland changeset: https://hg.mozilla.org/integration/autoland/rev/d31bc01c978f18af6b791b242a3a4575c415a2b6