1652973 - [wdspec] Use new window command in create_window fixture

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The new window command is supported by all the drivers as it looks like:

https://wpt.fyi/results/webdriver/tests/new_window/new_window.py?label=master&label=stable&aligned

To do so we would have to add an API to the webdriver client. An earlier attempt has been tried via this patch, but it was abandoned at the time.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1652973 - [wdspec] Move close() method of webdriver client into the Window class.

Depends on D83798

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1652973 - [wdspec] Replace create_window fixture with new window command.

Now that each driver supports the new window command, we can make use of it
as replacement for the create_window fixture.

Given that there is no need to check the type of the new window,
this implementation doesn't add a check for that.

Depends on D83799

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53cdfde742e4
[wdspec] Move close() method of webdriver client into the Window class. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/7ac192dc5d64
[wdspec] Replace create_window fixture with new window command. r=jgraham

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24647 for changes under testing/web-platform/tests

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/53cdfde742e4
https://hg.mozilla.org/mozilla-central/rev/7ac192dc5d64

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It looks like we have some upstream failures for infrastructure tests:

https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=51494&view=logs&jobId=af75b4de-b26f-5d4d-58e8-b41258076d44&j=af75b4de-b26f-5d4d-58e8-b41258076d44&t=052839da-7227-5391-fe2d-4b66ec169a0c

James, don't we run this kind of test in our own CI?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1652973 - [webdriver] Fix left-over for move of 'close()' method to window class.

Comment 9

[James Graham [:jgraham]]

We don't currently, but you can run them locally using ./mach wpt-unittest. Might not be too hard to set them up as a CI job iff tox is available on the images. Otherwise it's a bigger job.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb64d0a7a99c
[webdriver] Fix left-over for move of 'close()' method to window class. r=jgraham

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fb64d0a7a99c

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham