1653047 - Work around a clang crash in the nsXPCTestParams constructor

Status: RESOLVED FIXED

(Firefox Build System :: Toolchains, defect)

Description

[(Away)]

Mingw builds crash during compilation with clang 11 (possibly clang 10 also) with the symptoms at https://bugs.llvm.org/show_bug.cgi?id=46738.

The underlying issue goes back at least as far as clang 9 but for some reason we haven't triggered it so far.

Comment 1

[(Away)]

Attachment: Work around a clang crash in the nsXPCTestParams constructor

The combination of clang-11, mingw builds, and the recent constructor refactorings in this file, have revealed a previously unseen compiler crash: https://bugs.llvm.org/show_bug.cgi?id=46738.

The underlying issue is present in older clangs but for some reason we haven't triggered the right conditions for it until now.

For now, the easiest way forward is to move the constructors inline. I don't feel so bad about using a code workaround in this case, because this makes the code read more naturally anyway.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7eeab6b9979
Work around a clang crash in the nsXPCTestParams constructor r=sg

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c7eeab6b9979