1653083 - Add doorhanger telemetry for Credit Card A/B testing

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, enhancement, P1)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

As part of bug 1653073, we will add several event telemetry bits for doorhanger

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1653083 - Add doorhanger telemetry for Credit Card A/B testing. r?abr

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

I rebased my patch to be on top of bug 1653162 because that patch adds flowId.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f1edafeb236
Add doorhanger telemetry for Credit Card A/B testing. r=abr

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/3f1edafeb236

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 9163916 [details]
Bug 1653083 - Add doorhanger telemetry for Credit Card A/B testing. r?abr

Beta/Release Uplift Approval Request

• User impact if declined: None
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1653083, Bug 1653162, Bug 1654167
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It just adds telemetry to a preffed-off feature
• String changes made/needed: None

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9163916 [details]
Bug 1653083 - Add doorhanger telemetry for Credit Card A/B testing. r?abr

approved for 80.0b2

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7f5fba652845

Comment 14

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified the doorhanger telemetry for Credit Card implemented in this bug on Firefox 80.0b5 (Build ID: 20200806203447) and the latest Nightly 81.0a1 build (Build ID: 20200806215439) on Windows 10 x64, Mac 10.14.6, Linux Mint 19.2and Ubuntu 20.04 x64.
In order to verify this we have used the Credit Card Autofill Metrics Spec document and the following events are correctly registered:

• creditcard capture_doorhanger show flow_id
• creditcard capture_doorhanger save flow_id
• creditcard capture_doorhanger disable flow_id
• creditcard capture_doorhanger cancel flow_id
• creditcard update_doorhanger show flow_id
• creditcard update_doorhanger update flow_id
• creditcard update_doorhanger save flow_id