1653162 - Add credit-card form telemetry for Credit Card A/B testing

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, enhancement, P1)

Description

[Adam Roach [:abr]]

+++ This bug was initially created as a clone of Bug #1653083 +++

As part of bug 1653073, we will add several event telemetry bits for the user's interaction with a credit card autofill form

Comment 1

[Adam Roach [:abr]]

Attachment: Bug 1653162: Add telemetry reporting for autofill events. r?zbraniecki

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e38530aaba0
Add telemetry reporting for autofill events. r=zbraniecki

Comment 3

[Adam Roach [:abr]]

Taking ownership so I'll get the ni? if the patch causes issue in integration.

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 4e38530aaba0 (Bug 1653162) for causing failures in test_autofillFormFields.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=J_whxh_DSP6wLB37efD6Xg.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=4e38530aaba05ad766ff36138ab669a960b31599

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311005201&repo=autoland&lineNumber=3723
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311006131&repo=autoland&lineNumber=1460
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311010872&repo=autoland&lineNumber=1580

Backout: https://hg.mozilla.org/integration/autoland/rev/eb5efb09b85c4a4fd6b6832deda6f66f1ec0e16b

Comment 5

[Natalia Csoregi [:nataliaCs]]

Also failing: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311010887&repo=autoland&lineNumber=4774

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8c77af2ee9f
Add telemetry reporting for autofill events. r=zbraniecki

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e8c77af2ee9f

Comment 12

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 9163940 [details]
Bug 1653162: Add telemetry reporting for autofill events. r?zbraniecki

Beta/Release Uplift Approval Request

• User impact if declined: None
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1653083, Bug 1654167
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It just adds telemetry to a preffed-off feature
• String changes made/needed: None

Comment 13

[Julien Cristau [:jcristau]]

This bug/change doesn't seem to have data-review?

Comment 14

[Julien Cristau [:jcristau]]

Or is that all part of the review in bug 1653073?

Comment 15

[Adam Roach [:abr]]

(In reply to Julien Cristau [:jcristau] from comment #14)

Or is that all part of the review in bug 1653073?

Yes.

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 9163940 [details]
Bug 1653162: Add telemetry reporting for autofill events. r?zbraniecki

approved for 80.0b2

Comment 17

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e0bc1b04cbfe

Comment 18

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified the telemetry for the credit-card form implemented in this bug on Firefox 80.0b5 (Build ID: 20200806203447) and the latest Nightly 81.0a1 build (Build ID: 20200806215439) on Windows 10 x64, Mac 10.14.6, Linux Mint 19.2and Ubuntu 20.04 x64.
In order to verify this we have used the Credit Card Autofill Metrics Spec document (row #14 - #18)and the following events are correctly registered:

• creditcard cc_form detected flow_id
• creditcard cc_form popup_shown flow_id
• creditcard cc_form filled flow_id
• creditcard cc_form filled_modified flow_id
• creditcard cc_form submitted flow_id

However, while verifying these telemetry I have encountered the following issues for the cc_form submitted event:

1. The {"category:creditcard", "method:submitted") event is not registered in the Control branch while the CC autofill feature is pref'd off. This issue is logged in Bug 1653083.
2. The blank fields are wrongly recorded as "field_modified" when manually complete and submit a form. This issue is logged in Bug 1657909.