1653195 - eslint is conflicted about what version of eslint-visitor-keys to require

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P1)

Description

[:Gijs (he/him)]

The m-c global package-lock.json file says:

    "eslint-visitor-keys": {
      "version": "1.3.0",
      "resolved": "https://registry.npmjs.org/eslint-visitor-keys/-/eslint-visitor-keys-1.3.0.tgz",
      "integrity": "sha512-6J72N8UNa462wa/KFODt/PJ3IU60SDpC3QXC1Hjc1BXXpfL2C9R5+AU7jhe0F6GREqVMh4Juu+NY7xn+6dipUQ==",
      "dev": true
    },

But the eslint mozilla plugin requires 1.2.0:

        "eslint-visitor-keys": {
          "version": "1.2.0",
          "resolved": "https://registry.npmjs.org/eslint-visitor-keys/-/eslint-visitor-keys-1.2.0.tgz",
          "integrity": "sha512-WFb4ihckKil6hu3Dp798xdzSfddwKKU3+nGniKF6HfeW6OLd2OUDEPP7TcHtB5+QXOKg2s6B2DaMPE1Nn/kxKQ==",
          "dev": true
        }

This (or some other package.json / package-lock.json conflict?) appears to result in all my machines (my mac, my linux vm, etc.) that have the linter configured to run as a commit hook, getting output along the lines of:

eslint-visitor-keys v1.3.0 should be v1.2.0.
Installing eslint for mach using "path/to/.mozbuild/node/bin/node path/to/.mozbuild/node/bin/npm ci --loglevel=error --scripts-prepend-node-path"...

eslint installed successfully!

NOTE: Your local eslint binary is at path/to/mozilla-central/node_modules/.bin/eslint

every time I commit, and commits are correspondingly delayed...

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1652130

Comment 2

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5abfdc36b2fec02fce3cad8f62fabb64a7e25486

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1653195 - Update eslint-plugin-mozilla's eslint-visitor-keys to be the same as the top-level include. r?Mossop!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27d4f2761c88
Update eslint-plugin-mozilla's eslint-visitor-keys to be the same as the top-level include. r=mossop

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/27d4f2761c88