1653246 - Optimize DataView get/set methods in CacheIR and Warp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P1)

Description

[Jan de Mooij [:jandem]]

anba added Ion optimizations for this in bug 1065894. I started looking into porting the get* methods to CacheIR and it seems doable.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1653246 part 1 - Add offsetIsInBounds and infallible read methods to DataViewObject. r?anba!

Some refactoring to move the bounds check out of getDataPointer into the
callers (read and write). This seems a bit more natural and this way
getDataPointer is infallible (can assert offset is in bounds), doesn't need
the cx argument, and can be non-static.

This also factors out an infallible DataViewObject::read method, it will be used
in the next patch.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1653246 part 2 - Add a helper method for Uint32 to Int32Value/DoubleValue. r?anba!

Depends on D83904

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1653246 part 3 - Add GuardClassKind::DataView. r?anba!

Depends on D83905

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1653246 part 4 - Optimize DataView get* methods in CacheIR. r?anba!

Depends on D83906

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1653246 part 5 - Optimize DataView set* methods in CacheIR. r?anba!

Pretty similar to the last patch. The register situation on 32-bit x86 complicates
this a bit unfortunately.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c41eb4ac1688
part 1 - Add offsetIsInBounds and infallible read methods to DataViewObject. r=anba
https://hg.mozilla.org/integration/autoland/rev/f38994f1ae8c
part 2 - Add a helper method for Uint32 to Int32Value/DoubleValue. r=anba
https://hg.mozilla.org/integration/autoland/rev/750770bf3191
part 3 - Add GuardClassKind::DataView. r=anba
https://hg.mozilla.org/integration/autoland/rev/4410c368a84a
part 4 - Optimize DataView get* methods in CacheIR. r=anba

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c41eb4ac1688
https://hg.mozilla.org/mozilla-central/rev/f38994f1ae8c
https://hg.mozilla.org/mozilla-central/rev/750770bf3191
https://hg.mozilla.org/mozilla-central/rev/4410c368a84a

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79a8c6e09dbf
part 5 - Optimize DataView set* methods in CacheIR. r=anba

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/79a8c6e09dbf

Comment 10

[Jan de Mooij [:jandem]]

Attachment: Bug 1653246 part 6 - Transpile DataView instructions. r?anba!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11c2cba699e4
part 6 - Transpile DataView instructions. r=anba

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/11c2cba699e4