1653323 - Show print preview progress in content

Status: RESOLVED FIXED

(Toolkit :: Printing, enhancement, P1)

Description

[Mark Striemer [:mstriemer]]

A progress dialog is shown as the print preview is being rendered, this is currently a popup with a cancel button.

Since we'll have the print UI available the regular cancel can be used for cancelling.

Rather than showing the dialog we should have a placeholder spinner/progress indiciator where the preview will eventually go.

Comment 1

[Emma Malysz]

Attachment: Bug 1653323: show print preview progress in the print preview browser when preview is being rendered.

WIP that needs cleaning up. Introduces a new html doc that holds the "Preparing Print Preview" label and
the pending animation.
I need to find an appropriate place to put that code (TODO). Right now, pausing at the debugger statement
would show what it may look like.

Comment 2

[Mark Striemer [:mstriemer]]

jwatt just pointed me to the showPrintProgress print setting we can use to disable the dialog when the preview is being generated. This should disable the dialog for the modal but leave it for the full-screen version.

diff --git a/toolkit/actors/PrintingChild.jsm b/toolkit/actors/PrintingChild.jsm
--- a/toolkit/actors/PrintingChild.jsm
+++ b/toolkit/actors/PrintingChild.jsm
@@ -311,16 +311,22 @@ class PrintingChild extends ActorChild {
     simplifiedMode,
     changingBrowsers,
     lastUsedPrinterName
   ) {
     const { docShell } = this;
     try {
       let printSettings = this.getPrintSettings(lastUsedPrinterName);

+      // Disable the progress dialog for generating previews.
+      printSettings.showPrintProgress = !Services.prefs.getBoolPref(
+        "print.tab_modal.enabled",
+        false
+      );
+
       // If we happen to be on simplified mode, we need to set docURL in order
       // to generate header/footer content correctly, since simplified tab has
       // "about:blank" as its URI.
       if (printSettings && simplifiedMode) {
         printSettings.docURL = contentWindow.document.baseURI;
       }

       // The print preview docshell will be in a different TabGroup, so

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35842513b5f7
show print preview progress in the print preview browser when preview is being rendered. r=fluent-reviewers,flod,jaws

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/35842513b5f7