1653348 - Add test cases to cover current collection of add-ons Telemetry data

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[William Durand [:willdurand]]

We have various add-ons related data in Telemetry (see Bug 1653028). Let's add some test cases to make sure that nobody removes it without us noticing.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1653348 - Add test case to cover current collection of add-ons Telemetry data. r=zombie,rpl

I don't know how to force-update the 'environment.addons.activeAddons'
field in the current ping data so this isn't covered with assertions,
but we make sure that this field is still there at least (despite no
coverage of the exposed properties).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c69d81ccdd2
Add test case to cover current collection of add-ons Telemetry data. r=rpl

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for xpcshell failures on test_amo_stats_telemetry.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=9c69d81ccdd28d940ecf5c936e611e4a1bf67b4d&failure_classification_id=2&selectedTaskRun=HlzNnMZ7RRyF12dotLkdow.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=310619246&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/986960f3dd902342c4720980dea94b3138e3ef9a

Comment 4

[William Durand [:willdurand]]

Sorry, it looks like local dev and CI don't have the exact same Telemetry settings. I updated the patch with the use of a pref to fix the problem.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1182c66cfee
Add test case to cover current collection of add-ons Telemetry data. r=rpl

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b1182c66cfee