1653480 - No warning dialog on closing multiple tabs

Status: UNCONFIRMED

(Firefox :: Tabbed Browser, defect)

Description

[sanyen_1st]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Close multiple tabs, either tabs to the right or other tabs.

Actual results:

No warning dialog appear.
No effect on changing this parameters:
browser.tabs.warnOnClose;true
browser.tabs.warnOnCloseOtherTabs;true

I have lot of tabs, restoring all tabs will reload all tabs and make my computer stress.

Expected results:

a warning dialog opens asking confirmation Close to the Right or Close other tabs.
"You are about to close to the Right, there is 2 tabs...Continue?" [Cancel][Close Tabs]
"You are about to close Other tabs, there is 100 tabs...Continue?" [Cancel][Close Tabs]

Because "close to the right" and "close other tabs" menu is very near, people can accidently clicking wrong choice.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dao, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Tanner Drake]

Able to reproduce on Debian 10.

Comment 4

[Tanner Drake]

(In reply to Tanner Drake from comment #3)

Able to reproduce on Debian 10.

on Nightly 82.0a1 (2020-09-28) (64-bit)

Comment 5

[Tanner Drake]

Attachment: Bug 1653480: Fix warnAboutClosingTabs to respect bool prefs for warnOnCloseOtherTabs. r=mconley

Comment 6

[Dão Gottwald [:dao]]

jaws, is this a valid bug?

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

We attempted to mitigate this by moving the bulk tab-closing menuitems to a submenu so they are not accidentally clicked as easily. We will prompt if the number of tabs being closed is greater than the browser.sessionstore.max_tabs_undo pref. It is my opinion that we should not take this patch.

Comment 8

[Tanner Drake]

I can understand that logic but is it not still clearly ignoring the browser.tabs.warnOnCloseOtherTabs pref?

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

That pref is not ignored. That pref is only used if the number of tabs is greater than the max_tabs_undo pref. Are you not seeing the dialog if you lower the max_tabs_undo number or if you close more than 25 tabs?

Comment 10

[Tanner Drake]

You do see the dialog when reaching the max_tabs_undo but my thinking was that browser.tabs.warnOnCloseOtherTabs should work similar to browser.tabs.warnOnClose which prompts for tabs > 1 and < max_tabs.

Comment 11

[sanyen_1st]

As I said before, undoing multiple tabs would reload/redownload all closed tabs, that made firefox and my pc hang up.
Usually I kill the firefox process and restore the last sessions rather than undoing multiple tabs.
It feels like getting a local ddos attack :)

Comment 12

[eyal gruss]

i select multiple tabs to move to end. then sometimes i close the active moved tab without noticing that other tabs are still selected and are being closed without any indication. please allow me to get a warning in this case.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:dao, could you have a look please?
For more information, please visit auto_nag documentation.