1653750 - Address book icons in Composition Options invisible in dark mode

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Andreas]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.89 Safari/537.36 Edg/84.0.522.40

Steps to reproduce:

Set Thunderbird to dark mode. Go to Options -> Composition -> Addressing.
Open the lists "Automatically add outgoing..." and "Default startup directory...".

Actual results:

The address book icons are barely visible in dark mode.

Expected results:

Icons should have a light color in dark mode.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1653750-menu-iconic-icon-fill-color.patch

Add the fill rules to the menu-iconic-icon.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9164593 [details] [diff] [review]
1653750-menu-iconic-icon-fill-color.patch

Review of attachment 9164593 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9164593 [details] [diff] [review]
1653750-menu-iconic-icon-fill-color.patch

[Approval Request Comment]
User impact if declined: very poorly visible icon in the menulist
Testing completed (on c-c, etc.): on the way to c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3e76868621c9
Set the fill color on menu-iconic-icon (to make Address book icons in Composition Options not invisible in dark mode). r=aleca

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9164593 [details] [diff] [review]
1653750-menu-iconic-icon-fill-color.patch

Approved for beta  (TBD if we actually uplift to 79 or not)
Approved for esr78

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 79.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/c73f31c114ed

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.1.0:
https://hg.mozilla.org/releases/comm-esr78/rev/d205654e6a64