1653937 - Read top site defaults from remote settings

Status: RESOLVED FIXED

(Firefox :: Top Sites, task, P2)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1653937 - Read top site defaults from remote settings. r=mikedeboer

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/555de96d4f49
Read top site defaults from remote settings. r=mikedeboer

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 555de96d4f49 (Bug 1653937) as requested by dao.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a48154f05b266759429422499787b2d925701c58

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=555de96d4f49ef1bb0684c27c458f10958124ec5&selectedTaskRun=cNdxtFv7Rnm1rXjPUJD7PQ.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313885551&repo=autoland&lineNumber=115

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a0556195f9d
Read top site defaults from remote settings. r=mikedeboer

Comment 5

[Alexandru Michis [:malexandru]]

Also seeing related bc failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=windows%2C10%2Cx64%2Cwebrender%2Copt%2Cmochitests%2Ctest-windows10-64-qr%2Fopt-mochitest-browser-chrome-e10s%2Cbc2&tochange=555de96d4f49ef1bb0684c27c458f10958124ec5&fromchange=c4a5371dcac9601e3b28f7e3033e5c6908937d5b&selectedTaskRun=OkuU7SQkTfeALv-GGR5Jhw.0

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9a0556195f9d

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 9171720 [details]
Bug 1653937 - Read top site defaults from remote settings. r=mikedeboer

Beta/Release Uplift Approval Request

• User impact if declined: This is a crucial part of moving top sites to remote settings rather than being hardcoded. This is needed in 81 for partner-related changes.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: QA has or is working on a test plan for this.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is still disabled by default for the time being.
• String changes made/needed:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9171720 [details]
Bug 1653937 - Read top site defaults from remote settings. r=mikedeboer

Approved for 81.0b2.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/124c6ccf178e