1653945 - Primary Password prompt is displayed right after typing in the first character of the password field in a specific scenario

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Recording of the issue

Affected Versions
Nightly 80.0a1 (2020-07-19) (64-bit)

Tested on
Windows 10 x64

Steps to reproduce

1. Have a profile with MP and saved credentials on Facebook
2. Go to Facebook, dismiss the MP prompt when it appears
3. Fill in the username and start to fill in the password field

Expected
The Primary Password prompt should be displayed after the user unfocuses the field

Actual
Primary Password prompt appears right after typing in the first character and the rest of the password input is continued from the password field into the primary password prompt

Regression-Range
Did not perform mozregression yet, but looking at Bug 1612258 as the regressor since the dismissed doorhanger key appears right after typing in 1 character instead of unfocusing the password field. In Beta builds (where Bug 1612258 is absent) the primary password prompt appears after unfocusing the password field -at the time when the dismissed doorhanger key is displayed.

Note
See attached recording for Nightly and Beta comparison. Marking this as a regression of Bug 1612258 for now.
Can be reproduced only by following Step 1 scenario. Can't be reproduced if there are no credentials already saved on the site and Primary Password dismissed.

Comment 1

[Pascal Chevrel:pascalc]

Bianca, could you look at this regression from bug 1612258 please? Thanks

Comment 2

[Bianca Danforth [:bdanforth]]

Attachment: Bug 1653945 - Do not show Primary Password prompt on 'input' and 'change' events. r=MattN

Comment 3

[Bianca Danforth [:bdanforth]]

Expected behavior: If Primary Password is enabled, but locked (i.e. the user has not authenticated with their Primary Password for the current session), there should be no dismissed doorhanger (and consequently no Primary Password dialog) on editing a password field or blurring an edited password field.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ed67234584e
Do not show Primary Password prompt on 'input' and 'change' events. r=MattN

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1ed67234584e

Comment 6

[Bianca Danforth [:bdanforth]]

Comment on attachment 9166466 [details]
Bug 1653945 - Do not show Primary Password prompt on 'input' and 'change' events. r=MattN

Beta/Release Uplift Approval Request

• User impact if declined: If the user has Primary Password enabled, but it is locked (i.e. they have not authenticated yet), then the Primary Password dialog will show on entering a single key into a password field on a page (e.g. a login page).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See the description in the bug for STR. The new expected behavior is described in Comment #3.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Primary Password is disabled by default in Firefox. Only about 1% of users have it enabled.

This bug only occurs when Primary Password is still locked when the user edits a password field on a page. There are a number of ways that the Primary Password dialog could show prior to this scenario which would give the user the opportunity to unlock Primary Password and avoid this bug entirely for a given session (e.g. if the user already has a saved login for the site, as shown in the video in the Description).

• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9166466 [details]
Bug 1653945 - Do not show Primary Password prompt on 'input' and 'change' events. r=MattN

regression fix, approved for 80.0b3

Comment 8

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f4770194c4a7

Comment 9

[Andrei Purice]

Reproduced on 80.0a1 (20200720094507) on Windows 10 x64.
Verified > Fixed in 81.0a1 (20200802214843) and 80.0b3 (20200803045446) on Windows 10 x64.