1654004 - Perma browser/base/content/test/static/browser_parsable_css.js | Unused whitelist item: {"sourceName":"/(?:res|gre-resources)\\/forms\\.css$/i","errorMessage":"/Expected color but found \\u2018-moz.*/i", when Gecko 81 merges to Beta on 2020-07-27

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=79ef7ee6d60bd6c39f4a39ccf38ad1a26b4d8975&selectedTaskRun=H3RQuymhSridkQReuMDv4w.0

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=310390702&repo=try

[task 2020-07-20T14:25:42.350Z] 14:25:42 INFO - TEST-PASS | browser/base/content/test/static/browser_parsable_css.js | All the styles (229) loaded without errors. -
[task 2020-07-20T14:25:42.351Z] 14:25:42 INFO - Buffered messages finished
[task 2020-07-20T14:25:42.351Z] 14:25:42 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Unused whitelist item: {"sourceName":"/(?:res|gre-resources)\/forms\.css$/i","errorMessage":"/Expected color but found \u2018-moz.*/i","platforms":["linux"],"isFromDevTools":false} -
[task 2020-07-20T14:25:42.351Z] 14:25:42 INFO - Stack trace:
[task 2020-07-20T14:25:42.351Z] 14:25:42 INFO - chrome://mochikit/content/browser-test.js:test_ok:1299
[task 2020-07-20T14:25:42.351Z] 14:25:42 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkWhitelist:483
[task 2020-07-20T14:25:42.351Z] 14:25:42 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:487
[task 2020-07-20T14:25:42.352Z] 14:25:42 INFO - Leaving test bound checkAllTheCSS

Caused by bug 1643246?

Comment 1

[Cameron McCormack (:heycam)]

Thanks, yes, though not sure why it only fails as beta?

Comment 2

[Cameron McCormack (:heycam)]

Ah, it's not bug 1643246, but bug 1635675 causing some rules to fail to parse.

Comment 3

[Cameron McCormack (:heycam)]

Fail to parse as a non-UA sheet, that is.

Comment 4

[Cameron McCormack (:heycam)]

Actually I guess it is bug 1643246 in that it removed the last non-pref-controlled usage of a system color in forms.css.

Comment 5

[Cameron McCormack (:heycam)]

Attachment: Bug 1654004 - Tweak browser_parsable_css.js to account for other rules when the ::file-chooser-button pref is disabled.

Comment 6

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2669efdee781b7a6acb7a5bb67852268ae4f5538

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22dc10936a4d
Tweak browser_parsable_css.js to account for other rules when the ::file-chooser-button pref is disabled. r=emilio

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/22dc10936a4d

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=c1fd5b90ad1f89efc1617cb52402783c81b115f9