1654341 - Use of unknown property Ci.nsIAutoCompletePopup.TEXTVALUE_REASON_COMPLETESELECTED

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Mark Banner (:standard8)]

I just discovered this use of an unknown property:

https://searchfox.org/mozilla-central/rev/3b6958c26049c1e27b2790a43154caaba9f6dd4a/browser/extensions/formautofill/FormAutofillHandler.jsm#656

browser/extensions/formautofill/FormAutofillHandler.jsm
  656:14  error  Use of unknown property Ci.nsIAutoCompletePopup.TEXTVALUE_REASON_COMPLETESELECTED

That should probably use nsIAutoCompleteInput, however, looking at the uses of setTextValueWithReason we can probably drop the reason argument altogether as neither of the implementations actually use it.

The slight complication would be what to rename the function to as there's already a SetTextValue in c++ which does something slightly different.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1604807

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:MattN, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Adam Roach [:abr]]

Fixed by Bug 1658086

Comment 4

[Alin Ilea, Desktop QA]

Hi Adam,
Is there a way for us to verify this manually or manual testing is not required in this case?
Thanks.

Comment 5

[Adam Roach [:abr]]

(In reply to Alin Ilea from comment #4)

Hi Adam,
Is there a way for us to verify this manually or manual testing is not required in this case?
Thanks.

It's just a code-level change that isn't visible. If you want to verify it, you can run through a credit-card fill and then check the console to make sure that the specific error that Mark pasted into Comment 0 doesn't appear. But given that it's not visible to users, it's not clear that manual testing is warranted.

Comment 6

[Timea Cernea [:tbabos][inactive]]

Tried to reproduce this on Firefox RC 80 but didn't see the error in the console. The same goes for the latest Nightly 81, so this is indeed something we can't verify manually as Adam said. Adding qe- flag to mark this as not actionable on QA side for verification.