1658086 - Fix regressions caused by Bug 1604807

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Adam Roach [:abr]]

The solution employed by Bug 1604807 appears to cause some regressions in a handful of edge cases. The solution applied by 1604807 attempted to leverage an existing codepath in the formFillController class to prevent the modifications that are caused by autofill from triggering the pop-up.

To reverse these regressions, this bug proposes to undo the fix implemented in Bug 1604807 and instead block delivery of the field update event in the javascript code.

Comment 1

[Adam Roach [:abr]]

Attachment: Bug 1658086: Part 1: Revert Bug 1604807 r=zbraniecki!

Comment 2

[Adam Roach [:abr]]

Attachment: Bug 1658086: Part 2: Block `input` event delivery when autofill is filling fields r=zbraniecki!

Depends on D86462

Comment 3

[Adam Roach [:abr]]

I have manually verified that this alternate fix addresses the four bugs that identify Bug 1604807 as their regressor.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2ca3a2a51fe
Part 1: Revert Bug 1604807 r=zbraniecki
https://hg.mozilla.org/integration/autoland/rev/01bad1cefbe7
Part 2: Block `input` event delivery when autofill is filling fields r=zbraniecki

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a2ca3a2a51fe
https://hg.mozilla.org/mozilla-central/rev/01bad1cefbe7

Comment 6

[Timea Cernea [:tbabos][inactive]]

Setting up QE+ so we remember to verify this asap.

Comment 7

[Timea Cernea [:tbabos][inactive]]

Since all the actionable regressions were verified on QA side, marking this as verified-fixed.