1654429 - Fix failing CSS mochitests with cross-origin and Fission enabled

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P2)

Description

[Neha Kochar [:neha]]

These tests are marked as skipped/failed for cross-origin and Fission, and need to be fixed
layout/style/test/test_transitions_replacement_on_busy_frame.html

https://docs.google.com/spreadsheets/d/16G5AZhHWWow3rBgim4QBHzWXMIIJiky2SzXYgDMTTKY/edit#gid=1354562828&range=2:3

More info: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests

Comment 1

[Sean Voisen (:svoisen)]

Boris: Looks like we have one failing related to transitions. layout/style/test/test_transitions_replacement_on_busy_frame.html
Can you take a look when you have a moment? (If you haven't started on any M6c audits, this is higher priority.)

Comment 2

[Boris Chiou [:boris]]

Attachment: Screen Shot 2020-07-22 at 14.59.26.png

I'm trying to reproduce this issue locally on mac.

It seems layout/style/test/test_transitions_replacement_on_busy_frame.html is not marked as skip-if and failed-if in mochitest.ini, so I just run this command:

./mach test --enable-fission --enable-xorigin-tests layout/style/test/test_transitions_replacement_on_busy_frame.html

However, it passed. Is there anything I miss in the reproduce steps? Or is this reproducible only on Linux?

Comment 3

[Tahia K]

(In reply to Boris Chiou [:boris] from comment #2)

Created attachment 9165550 [details]
Screen Shot 2020-07-22 at 14.59.26.png

I'm trying to reproduce this issue locally on mac.

It seems layout/style/test/test_transitions_replacement_on_busy_frame.html is not marked as skip-if and failed-if in mochitest.ini, so I just run this command:

./mach test --enable-fission --enable-xorigin-tests layout/style/test/test_transitions_replacement_on_busy_frame.html

However, it passed. Is there anything I miss in the reproduce steps? Or is this reproducible only on Linux?

Hi Boris, the test failure was seen during this treeherder run, under test-linux1804-64/opt-mochitest-plain-fis-xorig-e10s-5: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec97fc16ca8f622267f8d9137fb6d54215726dbb&selectedTaskRun=OnCPwyqTRxe5JAfAFac83g.0

I'm on linux and I actually can't reproduce the failure locally either. This may more appropriate as an intermittent failure?

Comment 4

[Boris Chiou [:boris]]

(In reply to Tahia K from comment #3)

Hi Boris, the test failure was seen during this treeherder run, under test-linux1804-64/opt-mochitest-plain-fis-xorig-e10s-5: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec97fc16ca8f622267f8d9137fb6d54215726dbb&selectedTaskRun=OnCPwyqTRxe5JAfAFac83g.0

I'm on linux and I actually can't reproduce the failure locally either. This may more appropriate as an intermittent failure?

I re-run 4 more times for this test by the same treeherder run (note: 2/5 failure rate), and yes I think this is an intermittent failure. test_transitions_replacement_on_busy_frame.html needs the support of the OMTA (off main thread animation). Perhaps there are something wrong in OMTA.

BTW, it seems test_animation_omta.html is failed in XOrigin sheet. Not sure if it is related.

Comment 5

[Boris Chiou [:boris]]

Trying to tweak the waiting time from 300ms to 500ms:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42234882143a370282eadfa8b6aad77f55251cf2

Comment 6

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #5)

Trying to tweak the waiting time from 300ms to 500ms:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42234882143a370282eadfa8b6aad77f55251cf2

Looks good for now. I will upload this patch for now.

Comment 7

[Boris Chiou [:boris]]

Attachment: Bug 1654429 - Tweak waiting time of main thread.

In order to reduce the probability of the intermittent of
test_transitions_replacement_on_busy_frame.html, for Fission and Xorigin test,
I'd like to increase the while loop waiting time from 300ms to 500ms.
It seems I didn't see this failure at least in 10 times in treeherder run.

Comment 8

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #6)

(In reply to Boris Chiou [:boris] from comment #5)

Trying to tweak the waiting time from 300ms to 500ms:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=42234882143a370282eadfa8b6aad77f55251cf2

Looks good for now. I will upload this patch for now.

Looks like no intermittent now after applying my patch. I'd like to wait until Bug 1647720 goes into m-c.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

(In reply to Boris Chiou [:boris] from comment #4)

BTW, it seems test_animation_omta.html is failed in XOrigin sheet. Not sure if it is related.

test_animation_omta.html has been flaky since we moved OMTA thread to the sampler thread (bug 1467765) on WebRender. The fis-xorig tests run on the WebRender, right? I know the flakiness reason, but I haven't figured out a good way to resolve the flakiness. The flakiness is not a problem in the wild since the flakiness is due to a test-only API (nsIDOMWindowUtils.getOMTAStyle).

Comment 10

[Boris Chiou [:boris]]

Looks like M-fis-xori is running on Linux 18.04 x64 opt/debug (not webrender, based on the treeherder run). Perhaps it's not related to sampler thread. However, about this bug, I'm still not sure the root cause actually. This only happens on opt build with fis-xorigin.

Comment 11

[Boris Chiou [:boris]]

Unfortunately, I cannot reproduce this anymore on treeherder run after adding some logs (note: tried 20 retriggers but no failure). Perhaps this is a timing issue (e.g. timestamp issue), or maybe it is also related to Bug 1634945.

Comment 12

[Hiroyuki Ikezoe (:hiro)]

Isn't it possible that the root cause has been already fixed, then?

Comment 13

[Boris Chiou [:boris]]

Maybe. I am writing a patch which just updates mochitest.ini to try. Let's see what happens now.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=33da40f0527abcbd1bd834162f624d75237decb8

Comment 14

[Boris Chiou [:boris]]

Attachment: Bug 1654429 - Enable test_transitions_replacement_on_busy_frame.html for fission and xorigin.

Comment 15

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #13)

Maybe. I am writing a patch which just updates mochitest.ini to try. Let's see what happens now.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=33da40f0527abcbd1bd834162f624d75237decb8

Didn't see any failure related to this issue. I'd like to enable this test for fission-xorigin.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ad2fc2915b1
Enable test_transitions_replacement_on_busy_frame.html for fission and xorigin. r=hiro

Comment 17

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3ad2fc2915b1